Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc: add --as-needed link option #9232

Closed
wants to merge 1 commit into from
Closed

gcc: add --as-needed link option #9232

wants to merge 1 commit into from

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@cmsbuild, @smuzaffar, @iarspider, @aandvalenzuela can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 10, 2024 •
edited
Loading

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar smuzaffar marked this pull request as draft June 10, 2024 14:29
@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa4e05/39815/summary.html
COMMIT: 4d44ce6
CMSSW: CMSSW_14_1_X_2024-06-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9232/39815/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

@@@@ ----> OK  EDM Class Transients 
>> Checking EDM Class Version for src/DataFormats/EcalDigi/src/alpaka/classes_cuda_def.xml in libDataFormatsEcalDigiCudaAsync.so
@@@@ ----> OK  EDM Class Transients 
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsCTPPSDigi.so
error: class 'CTPPSDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 1554945820
error: class 'TotemRPDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 1915602617
error: class 'CTPPSDiamondDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 3253161212
error: class 'CTPPSPixelDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 1640295022
error: class 'TotemTimingDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 3647294361
>> Checking EDM Class Version for src/DataFormats/EcalDigi/src/alpaka/classes_rocm_def.xml in libDataFormatsEcalDigiROCmAsync.so

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa4e05/39825/summary.html
COMMIT: 4d44ce6
CMSSW: CMSSW_14_1_X_2024-06-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9232/39825/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa4e05/39825/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa4e05/39825/git-merge-result

Build

I found compilation error when building:

>> Checking EDM Class Transients in libDataFormatsCLHEP.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsCSCDigi.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsCSCRecHit.so
error: class 'CTPPSDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 1554945820
error: class 'TotemRPDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 1915602617
error: class 'CTPPSDiamondDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 3253161212
error: class 'CTPPSPixelDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 1640295022
error: class 'TotemTimingDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 3647294361
Suggestion: You can run 'scram build updateclassversion' to generate src/DataFormats/CTPPSDetId/src/classes_def.xml.generated with updated ClassVersion

@smuzaffar
Copy link
Contributor Author

add a special IB ASNEEDED to test this

@smuzaffar smuzaffar closed this Jun 26, 2024
@smuzaffar smuzaffar deleted the smuzaffar-patch-1 branch June 26, 2024 15:15
@fwyzard fwyzard mentioned this pull request Jul 9, 2024
Merged
@makortel makortel mentioned this pull request Jul 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smuzaffar @cmsbuild