-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLUE external library. #9231
Add CLUE external library. #9231
Conversation
A new Pull Request was created by @rovere for branch IB/CMSSW_14_1_X/master. @iarspider, @smuzaffar, @aandvalenzuela, @cmsbuild can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
please test |
@rovere , can you please rebase your changes on top of latest IB/CMSSW_14_1_X/master branch and add |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d80f8e/39802/summary.html Comparison SummarySummary:
|
Pull request #9231 was updated. |
8740426
to
738bc82
Compare
Pull request #9231 was updated. |
@smuzaffar let me know if that's what you asked for. |
cmssw-tools.spec
Outdated
@@ -146,6 +146,7 @@ Requires: dasgoclient | |||
Requires: dablooms | |||
Requires: zlib | |||
Requires: rivet | |||
Requires: clue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember why alpaka
is in the Linux-only section, but could you move clue
to the same spot, right after alpaka
itself ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fwyzard you are right, since clue depends on alpaka.
Did it, thanks.
738bc82
to
dfdabda
Compare
Pull request #9231 was updated. |
clue.spec
Outdated
### RPM external clue 1.0.0 | ||
## NOCOMPILER | ||
|
||
%define git_commit V_1_0_0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rovere , can you please also change this to
%define git_commit V_%(echo %{realversion} | tr '.' '_')
this way in future we only need to update the version in the first line :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also change the release tag in GitHub to 1.0.0
:-)
looks good |
dfdabda
to
afa756e
Compare
Pull request #9231 was updated. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d80f8e/39813/summary.html Comparison SummarySummary:
|
REMINDER @rappoccio, @sextonkennedy, @antoniovilela: This PR was tested with cms-sw/cmssw#45178, please check if they should be merged together |
Hi @rappoccio @antoniovilela |
Yes, this external is needed to go with cms-sw/cmssw#45178 :
<use name="clue"/> |
+externals @cms-sw/orp-l2 , I am merging this for 14.1.X as it is needed by which is already merged |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
This addresses the issue here.