Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLUE external library. #9231

Merged

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Jun 8, 2024

This addresses the issue here.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2024

A new Pull Request was created by @rovere for branch IB/CMSSW_14_1_X/master.

@iarspider, @smuzaffar, @aandvalenzuela, @cmsbuild can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor

fwyzard commented Jun 9, 2024

please test

@smuzaffar
Copy link
Contributor

@rovere , can you please rebase your changes on top of latest IB/CMSSW_14_1_X/master branch and add clue dependency in cmssw-tools.spec.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d80f8e/39802/summary.html
COMMIT: 2dea0cd
CMSSW: CMSSW_14_1_X_2024-06-09-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9231/39802/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338974
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338945
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #9231 was updated.

@rovere rovere force-pushed the IB/CMSSW_14_1_X/master branch from 8740426 to 738bc82 Compare June 10, 2024 09:40
@cmsbuild
Copy link
Contributor

Pull request #9231 was updated.

@rovere
Copy link
Contributor Author

rovere commented Jun 10, 2024

@smuzaffar let me know if that's what you asked for.

cmssw-tools.spec Outdated
@@ -146,6 +146,7 @@ Requires: dasgoclient
Requires: dablooms
Requires: zlib
Requires: rivet
Requires: clue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why alpaka is in the Linux-only section, but could you move clue to the same spot, right after alpaka itself ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fwyzard you are right, since clue depends on alpaka.
Did it, thanks.

@rovere rovere force-pushed the IB/CMSSW_14_1_X/master branch from 738bc82 to dfdabda Compare June 10, 2024 09:54
@cmsbuild
Copy link
Contributor

Pull request #9231 was updated.

clue.spec Outdated
### RPM external clue 1.0.0
## NOCOMPILER

%define git_commit V_1_0_0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rovere , can you please also change this to

%define git_commit V_%(echo %{realversion} | tr '.' '_')

this way in future we only need to update the version in the first line :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also change the release tag in GitHub to 1.0.0 :-)

@smuzaffar
Copy link
Contributor

@smuzaffar let me know if that's what you asked for.

looks good

@rovere rovere force-pushed the IB/CMSSW_14_1_X/master branch from dfdabda to afa756e Compare June 10, 2024 11:52
@cmsbuild
Copy link
Contributor

Pull request #9231 was updated.

@fwyzard
Copy link
Contributor

fwyzard commented Jun 10, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d80f8e/39813/summary.html
COMMIT: afa756e
CMSSW: CMSSW_14_1_X_2024-06-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9231/39813/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 15 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338974
  • DQMHistoTests: Total failures: 851
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338103
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

REMINDER @rappoccio, @sextonkennedy, @antoniovilela: This PR was tested with cms-sw/cmssw#45178, please check if they should be merged together

@srimanob
Copy link

srimanob commented Jul 2, 2024

Hi @rappoccio @antoniovilela
Should this external PR also be merged? Thanks.

@fwyzard
Copy link
Contributor

fwyzard commented Jul 2, 2024

Yes, this external is needed to go with cms-sw/cmssw#45178 :

RecoLocalCalo/HGCalRecProducers/plugins/BuildFile.xml, line 49

  <use name="clue"/>

@smuzaffar
Copy link
Contributor

+externals

@cms-sw/orp-l2 , I am merging this for 14.1.X as it is needed by which is already merged

@smuzaffar smuzaffar merged commit 019ddb2 into cms-sw:IB/CMSSW_14_1_X/master Jul 2, 2024
9 checks passed
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants