Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tensorflow-xla-runtime.spec #9072

Merged
merged 7 commits into from
Mar 15, 2024
Merged

Update tensorflow-xla-runtime.spec #9072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
12475e4
Update tensorflow-xla-runtime.spec
iarspider Mar 15, 2024
5937cc5
Add arch_build_flags
iarspider Mar 15, 2024
cd486ca
Update tensorflow-xla-runtime.spec
iarspider Mar 15, 2024
86827d9
Update tensorflow-xla-runtime.spec
iarspider Mar 15, 2024
398bf38
Update tensorflow-xla-runtime.spec
iarspider Mar 15, 2024
38d1f64
Update env.file
iarspider Mar 15, 2024
651305d
Update tensorflow-xla-runtime.spec
iarspider Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scram-tools.file/tools/eigen/env.file
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
export CMS_EIGEN_CXX_FLAGS="-DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64"
if [ `uname -m` = "aarch64" ]; then
export CMS_EIGEN_CXX_FLAGS="-DEIGEN_NEON_GEBP_NR=4 ${CMS_EIGEN_CXX_FLAGS}"
fi
12 changes: 10 additions & 2 deletions tensorflow-xla-runtime.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
### RPM external tensorflow-xla-runtime 2.12.0
## INCLUDE cpp-standard
## INCLUDE compilation_flags

Source99: scram-tools.file/tools/eigen/env

Requires: eigen py3-tensorflow
BuildRequires: cmake
Expand All @@ -9,11 +12,16 @@ BuildRequires: cmake
cp -r ${PY3_TENSORFLOW_ROOT}/lib/python%{cms_python3_major_minor_version}/site-packages/tensorflow .

%build

source %{_sourcedir}/env
export CPATH="${CPATH}:${EIGEN_ROOT}/include/eigen3"

CXXFLAGS="-fPIC %{arch_build_flags} ${CMS_EIGEN_CXX_FLAGS}"
%ifarch x86_64
CXXFLAGS="${CXXFLAGS} -msse3"
%endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess adding -DEIGEN_NEON_GEBP_NR=4 for aarch64 should fix this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or better to update scram-tools.file/tools/eigen/env.file and add this flagfor aarch64 there


pushd tensorflow/xla_aot_runtime_src
cmake . -DCMAKE_CXX_FLAGS="-fPIC -msse3" -DCMAKE_CXX_STANDARD=%{cms_cxx_standard} -DBUILD_SHARED_LIBS=OFF
cmake . -DCMAKE_CXX_FLAGS="${CXXFLAGS}" -DCMAKE_CXX_STANDARD=%{cms_cxx_standard} -DBUILD_SHARED_LIBS=OFF
make %{makeprocesses}
popd

Expand Down