Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Using consistent Eigen alignment settings #9062

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

smuzaffar
Copy link
Contributor

Backport of #9060
It also contains changes from #9061 (which actually enable the vectorization package built of lwtnn, opencv and pytorch

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_14_1_X/master to IB/CMSSW_14_0_X/master March 11, 2024 21:49
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2024

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@iarspider, @cmsbuild, @aandvalenzuela, @smuzaffar can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7c924/38044/summary.html
COMMIT: d7a4d12
CMSSW: CMSSW_14_0_X_2024-03-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9062/38044/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7c924/38044/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7c924/38044/git-merge-result

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor Author

+externals

@rappoccio, @antoniovilela feel free to merge it for 14.0.X. This is needed to fix cms-sw/cmssw#44188 issue

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

urgent

@antoniovilela
Copy link

+externals

@rappoccio, @antoniovilela feel free to merge it for 14.0.X. This is needed to fix cms-sw/cmssw#44188 issue

We need #9061 to go in first, correct?

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Mar 12, 2024

yes @antoniovilela . #9061 is ready to go in ( I am just waiting for the comparison results for the multi-arch IB)

@antoniovilela
Copy link

yes @antoniovilela . #9061 is ready to go in ( I am just waiting for the comparison results for the multi-arch IB)

Thanks. Can the backport wait for the IB tests and be merged tomorrow? We will collect a few more PRs for the next 14_0 release (14_0_2).
@cms-sw/alca-l2

@smuzaffar
Copy link
Contributor Author

@antoniovilela , #9061 is merged now and will be part of tonight's 23h00 IBs. Feel free to merge this for 14.0.X tomorrow morning before 11h00 IB

@antoniovilela
Copy link

@antoniovilela , #9061 is merged now and will be part of tonight's 23h00 IBs. Feel free to merge this for 14.0.X tomorrow morning before 11h00 IB

Hi Shahzad, I might not make it before 11h (I am 4h behind). If I do not merge it tonight, feel free to merge it tomorrow morning.
Thanks.

@smuzaffar
Copy link
Contributor Author

@antoniovilela , 14.1.X IBs look good. So I am merging it now for 14.0.X

@smuzaffar smuzaffar merged commit 29f2742 into IB/CMSSW_14_0_X/master Mar 13, 2024
9 checks passed
@antoniovilela
Copy link

@antoniovilela , 14.1.X IBs look good. So I am merging it now for 14.0.X

Thanks.

@smuzaffar smuzaffar deleted the 140x-eigen-flags branch March 14, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants