Updated root to tip of branch master

[iarspider]

No description provided.

[iarspider]

test parameters:

• pull_requests = [ROOTMaster] Fix include for RNTuple* (redo of #44256) cmssw#44328
• release = CMSSW_14_1_ROOT6_X

[cmsbuild]

A new Pull Request was created by @iarspider for branch IB/CMSSW_14_1_X/rootmaster.

@iarspider, @smuzaffar, @aandvalenzuela, @cmsbuild can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[iarspider]

please test

[iarspider]

please abort

[iarspider]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8984c5/38011/summary.html
COMMIT: 06131de
CMSSW: CMSSW_14_1_ROOT6_X_2024-03-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9056/38011/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mmusich Refactor scatterer addition in aGblPoint to explicitly specify type for scatPrecision.inverse() cmssw#44340
• @Dr15Jones Add ESInputTag to VPSet default added to cfi file cmssw#44344
• @perrotta Fix tag for the SiPixelLorentzAngleSimRcd in the Phase2 MC GT cmssw#44356
• @sroychow Update gbl to V03-01-01 and millepede to V04-16-00 #9053

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8984c5/38011/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8984c5/38011/git-merge-result

Build

I found compilation error when building:

Copying tmp/el8_amd64_gcc12/src/Alignment/OfflineValidation/bin/DMRtrends/DMRtrends to productstore area:
>> Compiling  src/Alignment/OfflineValidation/bin/DiMuonVmerge.cc
>> Compiling  src/Alignment/OfflineValidation/bin/Options.cc
In file included from src/Alignment/OfflineValidation/bin/DiMuonVmerge.cc:19:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_ROOT6_X_2024-03-08-2300/src/Alignment/OfflineValidation/macros/loopAndPlot.C: In function 'void plotHistograms(std::vector, const std::vector&, bool, const TString&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_ROOT6_X_2024-03-08-2300/src/Alignment/OfflineValidation/macros/loopAndPlot.C:262:25: error: invalid use of incomplete type 'class TGraph'
  262 |   rp->GetLowerRefGraph()->GetYaxis()->SetTitle("ratio");
      |                         ^~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_ROOT6_X_2024-03-08-2300/src/Alignment/OfflineValidation/macros/loopAndPlot.C:14:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.31.01-03c8afb9feaafdf1e910f1aaad7f7e59/include/TRatioPlot.h:33:7: note: forward declaration of 'class TGraph'
   33 | class TGraph;


[iarspider]

please test

[iarspider]

please abort

[iarspider]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8984c5/38033/summary.html
COMMIT: 06131de
CMSSW: CMSSW_14_1_ROOT6_X_2024-03-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9056/38033/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 163 lines from the logs
• Reco comparison results: 910 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297383
• DQMHistoTests: Total failures: 6153
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3291210
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[guitargeek]

Finally! What are the reco and DQM differences like, are they bad? Or just some numeric differences?

Given that RooFit now uses this new backend with autovectorization, I would be interested to know (according to my validations), there should be only differences at the floating-precision level.

Sorry I don't have access to take a look myself.

[smuzaffar]

@guitargeek , Reco and DQM comparisons are expected as we compare ROOT 6.30 (default in cmssw) with ROOT master.
Even without latest root master changes we do see these differences e.g #8999 (comment) for a month old root master vs root 6.30

[guitargeek]

Fantastic, thanks!

[antoniovilela]

@smuzaffar
Hi Shahzad, is this good to go with cms-sw/cmssw/44328 ?
Thanks.

[smuzaffar]

yes @antoniovilela

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/rootmaster IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#44328

[antoniovilela]

+1