Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROOT: Use rootcling instead of genreflex for root dict generation #8984

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

smuzaffar
Copy link
Contributor

Fixes #8983

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2024

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_14_0_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5763a1/37219/summary.html
COMMIT: 515ac91
CMSSW: CMSSW_14_0_X_2024-02-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8984/37219/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5763a1/37219/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5763a1/37219/git-merge-result

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor Author

+externals

looks good but we will integrate it for 14.1.X

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2024

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_14_0_X/master to IB/CMSSW_14_1_X/master February 6, 2024 10:20
@smuzaffar
Copy link
Contributor Author

+externals

@makortel , any objection on this change?

@makortel
Copy link
Contributor

makortel commented Feb 6, 2024

No objections

@smuzaffar
Copy link
Contributor Author

lets get this in for next IB

@smuzaffar smuzaffar merged commit 6b0f130 into IB/CMSSW_14_1_X/master Feb 6, 2024
10 checks passed
@smuzaffar smuzaffar deleted the genreflex-rootcling branch March 14, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use rootcling instead of genreflex
3 participants