-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ROOT 6.14 to include forward-compatibility patch #8893
Conversation
@arooshap , I have set the commit status |
@arooshap , this is the PR which DQM team needs. |
@smuzaffar thanks for the confirmation. Yes, the bot should start testing soon. |
@arooshap , this is ready to go in. |
@smuzaffar we have to deploy this in CMSWEB. I will make a deployment today. Thank you for your help! |
thanks @arooshap , please ping me when this is deployed on cmsweb. |
@smuzaffar I just deployed it in vocms0731 (the pre-production VM). |
@smuzaffar AFAIK, this is where the bin-by-bin comparison is made, could you trigger a PR test to check if it works? Edit: From a simple test I did by opening a ROOT 6.30 file with the updated |
Thanks, there are couple if comparison job pending in jenkins. Hopefully those should be enough to test new dqm gui |
@nothingface0 , please check PR cms-sw/cmssw#43596 results and its DQM bin-by-bin comparison. It looks good to me |
Indeed, everything looks good and no errors in the logs from our side! |
Update ROOT 6.14 ref to include forward-compatibility patch for root files created by versions >=6.30.
Discussion here.
Initial issue here
FYI @nothingface0