Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch rivet, yoda, thepeg, fastjet and tkonlinesw to avoid deprecated warnings #8858

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2023

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_14_0_X/master.

@aandvalenzuela, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-049170/36314/summary.html
COMMIT: e9ccb58
CMSSW: CMSSW_14_0_X_2023-12-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8858/36314/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-049170/36314/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-049170/36314/git-merge-result

Comparison Summary

Summary:

  • You potentially added 27 lines to the logs
  • Reco comparison results: 10036 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3369386
  • DQMHistoTests: Total failures: 7089
  • DQMHistoTests: Total nulls: 278
  • DQMHistoTests: Total successes: 3361997
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 160466.597 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 8764.192 KiB Tracking/JetCore
  • DQMHistoSizes: changed ( 10024.0,... ): 756.855 KiB Tracking/Track
  • DQMHistoSizes: changed ( 10024.0,... ): 201.715 KiB Tracking/TrackTPPtLess09
  • DQMHistoSizes: changed ( 10024.0,... ): 180.709 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 10024.0,... ): 166.715 KiB Tracking/TrackBuilding
  • DQMHistoSizes: changed ( 10024.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 10024.0,... ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 13234.0,... ): 8667.796 KiB Tracking/JetCore
  • DQMHistoSizes: changed ( 13234.0,... ): 742.191 KiB Tracking/Track
  • DQMHistoSizes: changed ( 141.044 ): 0.082 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 312.0 ): ...
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 16 / 48 workflows

@iarspider
Copy link
Contributor

please test for CMSSW_14_0_DEVEL_X

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-049170/36327/summary.html
COMMIT: e9ccb58
CMSSW: CMSSW_14_0_DEVEL_X_2023-12-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8858/36327/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-049170/36327/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-049170/36327/git-merge-result

Comparison Summary

Summary:

  • You potentially added 59 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 10038 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3369386
  • DQMHistoTests: Total failures: 7102
  • DQMHistoTests: Total nulls: 277
  • DQMHistoTests: Total successes: 3361985
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 160481.56299999997 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 8764.192 KiB Tracking/JetCore
  • DQMHistoSizes: changed ( 10024.0,... ): 756.855 KiB Tracking/Track
  • DQMHistoSizes: changed ( 10024.0,... ): 201.715 KiB Tracking/TrackTPPtLess09
  • DQMHistoSizes: changed ( 10024.0,... ): 180.709 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 10024.0,... ): 166.715 KiB Tracking/TrackBuilding
  • DQMHistoSizes: changed ( 10024.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 10024.0,... ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 11634.0,... ): 1.360 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 8667.796 KiB Tracking/JetCore
  • DQMHistoSizes: changed ( 13234.0,... ): 742.191 KiB Tracking/Track
  • DQMHistoSizes: changed ( 141.044 ): ...
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 16 / 48 workflows

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-049170/36328/summary.html
COMMIT: e9ccb58
CMSSW: CMSSW_14_0_X_2023-12-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8858/36328/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 9953edb into IB/CMSSW_14_0_X/master Dec 5, 2023
15 checks passed
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2023

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the deprecated-warns-externals branch December 18, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants