Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Geant4] G4TransportationWithMsc: Always update momentum direction #8789

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Oct 27, 2023

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_3_X/master.

@iarspider, @aandvalenzuela, @smuzaffar can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e5014/35455/summary.html
COMMIT: 1e622ca
CMSSW: CMSSW_13_3_X_2023-10-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8789/35455/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e5014/35455/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e5014/35455/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 32 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 1073
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356305
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

please test

lets re-run based on latest IB

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e5014/35470/summary.html
COMMIT: 1e622ca
CMSSW: CMSSW_13_3_X_2023-10-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8789/35470/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e5014/35470/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e5014/35470/git-merge-result

Comparison Summary

Summary:

  • You potentially added 53 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 40 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 177
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3357199
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 60286.36699999999 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.119 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 23234.0,... ): 6580.484 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 23234.0,... ): 3467.001 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 23234.0 ): 0.016 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 23234.0,... ): 0.012 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 24834.0,... ): 0.012 KiB MessageLogger/Warnings
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 6 / 48 workflows

@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_3_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the smuzaffar-patch-2 branch November 2, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport bug fix for Geant4 11.1
2 participants