Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT6] Update ROOT to tip of branch master #8559

Conversation

aandvalenzuela
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_13_2_X/rootmaster.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-422e1b/33294/summary.html
COMMIT: 67d87ca
CMSSW: CMSSW_13_2_ROOT6_X_2023-06-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8559/33294/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-422e1b/33294/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-422e1b/33294/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_ROOT6_X_2023-06-19-2300/src/GeneratorInterface/Pythia8Interface/plugins/JetMatchingHook.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_ROOT6_X_2023-06-19-2300/src/GeneratorInterface/Pythia8Interface/plugins/PowhegResHook.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_ROOT6_X_2023-06-19-2300/src/GeneratorInterface/Pythia8Interface/plugins/LHAupLesHouches.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_ROOT6_X_2023-06-19-2300/src/GeneratorInterface/Pythia8Interface/plugins/Py8toJetInput.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_ROOT6_X_2023-06-19-2300/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_ROOT6_X_2023-06-19-2300/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:32:10: fatal error: Pythia8Plugins/PowhegHooksVincia.h: No such file or directory
   32 | #include "Pythia8Plugins/PowhegHooksVincia.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_ROOT6_X_2023-06-19-2300/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:32:10: fatal error: Pythia8Plugins/PowhegHooksVincia.h: No such file or directory
   32 | #include "Pythia8Plugins/PowhegHooksVincia.h"


@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-422e1b/33335/summary.html
COMMIT: 67d87ca
CMSSW: CMSSW_13_2_ROOT6_X_2023-06-21-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8559/33335/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testDataFormatsScoutingRun3 had ERRORS
---> test testDataFormatsScoutingRun2 had ERRORS

Comparison Summary

Summary:

  • You potentially removed 10 lines from the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3200270
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3200245
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_2_X/rootmaster IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants