Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontier_client to 2.10.1 #8447

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

iarspider
Copy link
Contributor

@iarspider iarspider commented Apr 18, 2023

v2_10_1 - 7 Apr 2023

  • Add Python bindings and related patch that CMS has been using.
  • Fix to compile with gcc 10.1's new default -f-no-common option.
  • Update fnget.py to its version 1.10, to work with the python3 on EL9.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_1_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@iarspider iarspider linked an issue Apr 18, 2023 that may be closed by this pull request
@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-137985/32030/summary.html
COMMIT: 67cf1cc
CMSSW: CMSSW_13_1_X_2023-04-18-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8447/32030/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

* The action "build-external+frontier_client+2.10.1-cb468812c76828f05c745346a58e33f4" was not completed successfully because Failed to build frontier_client. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/frontier_client/2.10.1-cb468812c76828f05c745346a58e33f4/log. Final lines of the log file:
gcc -Wall  -DFRONTIER_DEBUG -fPIC -DPIC -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/expat/2.1.0-5f6457b4c04e97afec6079bd7d2db998/include  -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/pacparser/1.4.0-cbf4a008ddde4856a4762d7e9b1d7846/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/zlib/1.2.11-3dfb2715f3608466b74431b80eb9d788/include -I./include -I. -c frontier_error.c
gcc -DFNAPI_VERSION="\"2.10.1\"" -Wall  -DFRONTIER_DEBUG -fPIC -DPIC -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/expat/2.1.0-5f6457b4c04e97afec6079bd7d2db998/include  -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/pacparser/1.4.0-cbf4a008ddde4856a4762d7e9b1d7846/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/zlib/1.2.11-3dfb2715f3608466b74431b80eb9d788/include -I./include -I. -c frontier_config.c
gcc -Wall  -DFRONTIER_DEBUG -fPIC -DPIC -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/expat/2.1.0-5f6457b4c04e97afec6079bd7d2db998/include  -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/pacparser/1.4.0-cbf4a008ddde4856a4762d7e9b1d7846/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/zlib/1.2.11-3dfb2715f3608466b74431b80eb9d788/include -I./include -I. -c fn-mem.c
gcc -Wall  -DFRONTIER_DEBUG -fPIC -DPIC -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/expat/2.1.0-5f6457b4c04e97afec6079bd7d2db998/include  -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/pacparser/1.4.0-cbf4a008ddde4856a4762d7e9b1d7846/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/zlib/1.2.11-3dfb2715f3608466b74431b80eb9d788/include -I./include -I. -c pacparser-dlopen.c
pacparser-dlopen.c:94:6: error: conflicting types for 'pacparser_setmyip'; have 'void(const char *)'
94 | void pacparser_setmyip(const char *ip)
|      ^~~~~~~~~~~~~~~~~
In file included from pacparser-dlopen.c:17:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/pacparser/1.4.0-cbf4a008ddde4856a4762d7e9b1d7846/include/pacparser.h:111:5: note: previous declaration of 'pacparser_setmyip' with type 'int(const char *)'
111 | int pacparser_setmyip(const char *ip                 // Custom IP address.


@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8447 was updated.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-137985/32100/summary.html
COMMIT: 6d67198
CMSSW: CMSSW_13_1_X_2023-04-24-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8447/32100/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460685
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460660
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

looks good, dqm differences are in MessageLogger

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 67bf639 into IB/CMSSW_13_1_X/master Apr 25, 2023
@iarspider iarspider deleted the update-frontier-client-2.10.1 branch April 26, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please upgrade frontier_client to 2.10.1
3 participants