Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[106X] Update tag for Configuration-Generator to V01-04-00 #8439

Merged
merged 2 commits into from
Apr 17, 2023
Merged

[106X] Update tag for Configuration-Generator to V01-04-00 #8439

merged 2 commits into from
Apr 17, 2023

Conversation

tvami
Copy link

@tvami tvami commented Apr 15, 2023 •
edited
Loading

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 15, 2023 •
edited
Loading

A new Pull Request was created by @tvami (Tamas Vami) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Apr 15, 2023 •
edited
Loading

The current Configuration-Generator tag for 10_6_X is V01-00-03, while the tag submitted here is V01-03-00

Is it correct to jump directly from V01-00-03 to the new V01-03-00 in 10_6_X? Were all intermediate tags only including additional files (in which case there are no issues in adding them) or where there some more convoluted changes instead?
It is true that we can always test that new tag in 10_6 and see what happens, but it would be great if @Saptaparna or someone else from generators could confirm.

@tvami tvami mentioned this pull request Apr 15, 2023
Merged
@perrotta
Copy link
Contributor

please test
(just to see what happens. However, I don't think this can be merged as such, unless some list with the content of the intermediate tags is provided)

@perrotta
Copy link
Contributor

Tag V01-00-03 corresponds to cms-data/Configuration-Generator#6 (see the message announcing the cmsdist tag at the end of the github thread)

The following ones are:

@tvami
Copy link
Author

tvami commented Apr 15, 2023

it includes fixes for long lived charginos, to be evaluated by generators

IIUC @qliphy was GEN L2 back then, maybe he remembers what happened. To me, it just seems like the analysis didnt use UL yet and then it was forgotten to be added later on.

Let me also tag @Saptaparna in this thread, since it seems to be a better place to discuss this than cms-data/Configuration-Generator#10

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef3d93/31987/summary.html
COMMIT: 95de579
CMSSW: CMSSW_10_6_X_2023-04-09-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8439/31987/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 102 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Author

tvami commented Apr 15, 2023

OK the unit test failure is not connected

@smuzaffar
Copy link
Contributor

@perrotta @tvami , normally it is fine to backport new data files in old release cycles. New data files do not break any thing and as data packages are only installed once on cvmfs so it is not an overhead for shared distribution. But I see cms-data/Configuration-Generator#7 where data files with respect to V01-00-03 are changed (e.g 465 files were updated to have an extra line with Block keyword). I do not know if this change will break any thing in 10.6.X or not.

If we want to be really safe then I can create CMSSW_10_6_X branch based on V01-00-03 tag and then can merge cms-data/Configuration-Generator#10 on top of it.

@perrotta
Copy link
Contributor

Thank you @smuzaffar

My impression, as well as the one of @tvami , is that the fixes in 7 were never backported to 10_6 simply because that analysis did not move yet on UL. And that without those fixes the generation of long lived charginos cannot even start in 10_6. We have asked confirmation to @cms-sw/generators-l2 for it.

If so, I would rather backport all those fixes at once and have them already available in case of needs, without attempting any gymnastic to backport only the newest ones.

Rather, I am noticing that for 10_6 there are two cmsdist queues:

  • CMSSW_10_6_X/gcc700 (this one)
  • CMSSW_10_6_X/gcc820

Are we supposed to backport to both them?

@smuzaffar
Copy link
Contributor

smuzaffar commented Apr 16, 2023 •
edited
Loading

Only CMSSW_10_6_X/gcc700 is active branch and in use for 10.6.X ( https://github.com/cms-sw/cms-bot/blob/master/config.map#L59 ). CMSSW_10_6_X/gcc820 was test branch for testing gcc8 , so no need to open any PR for this. We do not have 10.6.X Ibs for gcc8

@tvami
Copy link
Author

tvami commented Apr 16, 2023

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @tvami
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Apr 16, 2023
@tvami tvami changed the title [106X] Update tag for Configuration-Generator to V01-03-00 [106X] Update tag for Configuration-Generator to V01-04-00 Apr 16, 2023
@cmsbuild
Copy link
Contributor

Pull request #8439 was updated.

@tvami
Copy link
Author

tvami commented Apr 16, 2023

unhold

  • updated to the latest tag

@tvami
Copy link
Author

tvami commented Apr 16, 2023 •
edited
Loading

backport of #8440

@tvami
Copy link
Author

tvami commented Apr 16, 2023

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef3d93/31994/summary.html
COMMIT: 0863a82
CMSSW: CMSSW_10_6_X_2023-04-16-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8439/31994/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 102 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Author

tvami commented Apr 17, 2023

ciao @perrotta is the answer in cms-data/Configuration-Generator#7 (comment) satisfying and we can merge this or you really need an explicit approval from gen?

@Saptaparna
Copy link

Based on @smuzaffar's response, this is fine and won't affect anything else with regard to UL requests?
I am a bit unclear on the consequences of changing the tag.

@tvami
Copy link
Author

tvami commented Apr 17, 2023

hi @Saptaparna the change (that is besides my changes) includes fixes for long lived charginos. Based on what Mario said they never requested samples in UL, so in that sense there is no affect on existing UL requests. Mario also said

propagation would indeed be welcome for the future.

(in cms-data/Configuration-Generator#7 (comment))

@Saptaparna
Copy link

Spoke to Tamas.

+1

@tvami
Copy link
Author

tvami commented Apr 17, 2023

@cmsbuild , please test with cms-sw/cmssw#41359

  • since we are waiting, let me actually clean the tests up

@smuzaffar
Copy link
Contributor

+externals

looks good

@smuzaffar smuzaffar merged commit ee98d49 into cms-sw:IB/CMSSW_10_6_X/gcc700 Apr 17, 2023
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio rappoccio mentioned this pull request Apr 17, 2023
Closed
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef3d93/32006/summary.html
COMMIT: 0863a82
CMSSW: CMSSW_10_6_X_2023-04-16-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8439/32006/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 10 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 102 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok externals-approved fully-signed orp-pending requires-external tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tvami @cmsbuild @perrotta @smuzaffar @Saptaparna