Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT628] Updated root to tip of branch v6-28-00-patches #8425

Conversation

iarspider
Copy link
Contributor

No description provided.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_1_X/root628.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b9cf7/31781/summary.html
COMMIT: fc7439b
CMSSW: CMSSW_13_1_ROOT628_X_2023-04-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8425/31781/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b9cf7/31781/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b9cf7/31781/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testDataFormatsScoutingRun3 had ERRORS
---> test testDataFormatsScoutingRun2 had ERRORS
---> test HcalPFCuts_unittest had ERRORS

Comparison Summary

Summary:

  • You potentially added 2365 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 16
  • DQMHistoTests: Total histograms compared: 611309
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 611301
  • DQMHistoTests: Total skipped: 8
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 15 files compared)
  • Checked 151 log files, 78 edm output root files, 16 DQM output files
  • TriggerResults: no differences found

@iarspider
Copy link
Contributor Author

testDataFormatsScoutingRun{2,3} - also failing in IBs, cms-sw/cmssw#41222
HcalPFCuts_unittest - timeout

@iarspider iarspider requested a review from smuzaffar April 4, 2023 16:03
@smuzaffar
Copy link
Contributor

+externals
yes I also noticed that HcalPFCuts_unittest is timing out during external PR tests. I hope cms-sw/cmssw#41269 might fix the issue

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/root628 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@iarspider iarspider deleted the root-update-v6-28-00-patches-20230404 branch April 4, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants