Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BuildRules] Reorder Rocm flags so that those can override compilers flags #8285

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Feb 2, 2023

  • Reorder Rocm flags so that those can override compilers flags
  • Make ROCM_HOST and CUDA_HOST flags to match the other flags names e.g
    • REM_ROCM_HOST instead of ROCM_HOST_REM
    • REM_CUDA_HOST instead of CUDA_HOST_REM
  • Allow to add/remove cuda/rocm host flags via project config/BuildFile e.g. to remove special flags for ASAN/UBSAN which does bot work with rocm/cuda

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2023

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_0_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Feb 2, 2023

test parameters:

  • addpkg = HeterogeneousTest,HeterogeneousCore

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2023

Pull request #8285 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1787ea/30371/summary.html
COMMIT: 99cc383
CMSSW: CMSSW_13_0_X_2023-02-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8285/30371/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555464
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar merged commit 28f629a into IB/CMSSW_13_0_X/master Feb 3, 2023
@smuzaffar smuzaffar deleted the smuzaffar-patch-16 branch February 15, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants