Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hydjet.spec #8154

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Update hydjet.spec #8154

merged 1 commit into from
Nov 8, 2022

Conversation

wouf
Copy link
Contributor

@wouf wouf commented Oct 27, 2022

This PR is related to cms-sw/cmssw#39874

This PR is related to PR#39874
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wouf for branch IB/CMSSW_12_6_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef8929/28567/summary.html
COMMIT: cfd40da
CMSSW: CMSSW_12_6_X_2022-10-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8154/28567/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3384029
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3383995
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_6_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@wouf
Copy link
Contributor Author

wouf commented Nov 8, 2022

@perrotta We have to merge it to the same release as cms-sw/cmssw#39874 otherwise Hydjet1 will work wrong!

@smuzaffar smuzaffar merged commit 12d0bbf into cms-sw:IB/CMSSW_12_6_X/master Nov 8, 2022
@smuzaffar
Copy link
Contributor

@wouf , I have merged it and it should go in 11h00 IB today (which should also include cms-sw/cmssw#39874)

@wouf
Copy link
Contributor Author

wouf commented Nov 8, 2022

@smuzaffar Thank You!

@perrotta
Copy link
Contributor

perrotta commented Nov 8, 2022

Thank you @smuzaffar : I forgot it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants