Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT6] Updated root to tip of branch master #8133

Conversation

aandvalenzuela
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_12_6_X/rootmaster.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8133 was updated.

@aandvalenzuela
Copy link
Contributor Author

please test

@aandvalenzuela
Copy link
Contributor Author

@smuzaffar it builds now fine with the update. Can I update dd4hep in ROOT626 PR #8131 accordingly?

@smuzaffar
Copy link
Contributor

@aandvalenzuela , root 6.26 does not need latest dd4hep . So there is no need to update it there. But we should check with @cms-sw/simulation-l2 and @cms-sw/geometry-l2 that if it is OK to update dd4hep in 12.6.X/master

@aandvalenzuela
Copy link
Contributor Author

Hello @cms-sw/simulation-l2, @cms-sw/geometry-l2,

To summarize the discussion, we would like to update dd4hep to version v01-23 (released on Sep 30, 2022) in 12.6.X/master. Do you have any objections?

Thank you,
Andrea.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb91bb/28330/summary.html
COMMIT: 161cc72
CMSSW: CMSSW_12_6_ROOT6_X_2022-10-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8133/28330/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testDiMuonVertexMonitor had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16684 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3391158
  • DQMHistoTests: Total failures: 42312
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3348823
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.17 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): -0.170 KiB SiStrip/MechanicalView
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 5 / 46 workflows

@aandvalenzuela
Copy link
Contributor Author

please test

@aandvalenzuela
Copy link
Contributor Author

Unit Test testDiMuonVertexMonitor is also failing in ROOT6 IBs.

@smuzaffar
Copy link
Contributor

looks good

@smuzaffar smuzaffar merged commit ca7f9d5 into cms-sw:IB/CMSSW_12_6_X/rootmaster Oct 19, 2022
@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb91bb/28349/summary.html
COMMIT: 161cc72
CMSSW: CMSSW_12_6_ROOT6_X_2022-10-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8133/28349/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testDiMuonVertexMonitor had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 19068 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3391158
  • DQMHistoTests: Total failures: 46195
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3344940
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.584 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 2.584 KiB SiStrip/MechanicalView
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 6 / 46 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants