Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root update master 20220808 #8014

Conversation

iarspider
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2022

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_5_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@iarspider iarspider changed the base branch from IB/CMSSW_12_5_X/master to IB/CMSSW_12_5_X/rootmaster August 8, 2022 08:24
@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0caf82/26690/summary.html
COMMIT: 7e86e32
CMSSW: CMSSW_12_5_ROOT6_X_2022-08-07-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8014/26690/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestGeneratorInterfacePythia8InterfaceCompareExternal had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16479 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3691612
  • DQMHistoTests: Total failures: 38008
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3653581
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.372 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 2.372 KiB SiStrip/MechanicalView
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 5 / 50 workflows

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0caf82/26723/summary.html
COMMIT: 7e86e32
CMSSW: CMSSW_12_5_ROOT6_X_2022-08-07-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8014/26723/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-l1tstage2emulator_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-l1tstage2_dqm_sourceclient had ERRORS

Comparison Summary

Summary:

  • You potentially added 3481 lines to the logs
  • Reco comparison results: 16487 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3691594
  • DQMHistoTests: Total failures: 38730
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3652840
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 238.64800000000002 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 38.919 KiB HLT/HIG
  • DQMHistoSizes: changed ( 11634.0,... ): 0.461 KiB HLT/Filters
  • DQMHistoSizes: changed ( 11834.0 ): 2.372 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 6 / 50 workflows

@iarspider
Copy link
Contributor Author

+1

@iarspider iarspider merged commit 5f29cde into cms-sw:IB/CMSSW_12_5_X/rootmaster Aug 10, 2022
@iarspider iarspider deleted the root-update-master-20220808 branch August 10, 2022 14:01
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_5_X/rootmaster IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

hi @iarspider - please be sure to also update the modules IB with the same patch whenever updating the root master branch.
Thx-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants