Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update crab-dev to v3.220714 #7994

Conversation

novicecpp
Copy link
Contributor

Bump crab-dev to v3.220714.
Also remove unused wmcore_version.

cc: @belforte

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @novicecpp (Thanayut Seethongchuen) for branch IB/CMSSW_12_5_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@belforte
Copy link
Contributor

thanks @novicecpp , maybe you are still in time to also update crabserver version to latest one before @smuzaffar starts processing this. If not.. we'll do in next round

@cmsbuild
Copy link
Contributor

Pull request #7994 was updated.

@novicecpp
Copy link
Contributor Author

Done. I forgot that we have update in ServerUtilities.py file.
Thanks @belforte.

@aandvalenzuela
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b17ff/26241/summary.html
COMMIT: 56c7b5f
CMSSW: CMSSW_12_5_X_2022-07-13-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7994/26241/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b17ff/26241/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b17ff/26241/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3653966
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3653936
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@aandvalenzuela
Copy link
Contributor

Hi @novicecpp, @belforte,

Test have passed. Do you agree to merge?

Thank you

@novicecpp
Copy link
Contributor Author

Yes, please.

@aandvalenzuela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_5_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@aandvalenzuela aandvalenzuela merged commit 3c6dcb2 into cms-sw:IB/CMSSW_12_5_X/master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants