-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xrdcl-record package #7827
Add xrdcl-record package #7827
Conversation
A new Pull Request was created by @iarspider for branch IB/CMSSW_12_4_X/master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
Pull request #7827 was updated. |
please test |
@iarspider , we should also add the toolfile and include it in cmssw-tool-conf otherwise bot is not going to build it. |
xrdcl-record.spec
Outdated
@@ -0,0 +1,23 @@ | |||
### RPM external xrdcl-record 5.4.2 | |||
Source: https://github.com/xrootd/xrdcl-record/archive/refs/tags/v5.4.2.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use %{realversion}
instead of hardcoded version string here
Pull request #7827 was updated. |
Pull request #7827 was updated. |
please test |
<tool name="xrdcl-record" version="@TOOL_VERSION@"> | ||
<lib name="XrdClRecorder-5"/> | ||
<client> | ||
<environment name="XRDCL-RECORD_BASE" default="@TOOL_ROOT@"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change this to XRDCL_RECORD_BASE
i.e use of _
instead of -
Pull request #7827 was updated. |
Pull request #7827 was updated. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-095e10/24262/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
Please test for el8_ppc64le_gcc10 |
Please test for el8_aarch64_gcc10 |
Please test for el9_amd64_gcc11 |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-095e10/24293/summary.html |
Great! Thank you @smuzaffar and @iarspider |
sure, I will open a PR for 12.3.X now |
-1 Failed Tests: UnitTests RelVals Unit TestsI found errors in the following unit tests: ---> test TestFWCoreServicesDriver had ERRORS RelVals
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-095e10/24292/summary.html Comparison SummarySummary:
|
Closes #7826