Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Millepede to V04-11-01 and switch to git #7660

Merged
merged 1 commit into from
Mar 5, 2022
Merged

Update Millepede to V04-11-01 and switch to git #7660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions millepede.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
### RPM external millepede V04-09-01

Source: svn://svnsrv.desy.de/public/MillepedeII/tags/%{realversion}/?scheme=http&module=%{realversion}&output=/%{n}-%{realversion}.tgz
### RPM external millepede V04-11-01
%define tag 9ee817fc61fe3e1b6543a8a16f7bcd8e1f8c331f
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iarspider @smuzaffar for my own education from where does this tag come from?
If I look at: https://gitlab.desy.de/claus.kleinwort/millepede-ii/-/tags the tag corresponding to version V04-11-01 is rather 4f288098f84f274f5a241f921035af77bc07d5c8?
Can you explain?
Thanks
Cc: @consuegs

Copy link
Contributor Author

@iarspider iarspider Mar 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I will open a follow-up PR now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmusich , you are right, the commit does not match the tag. @iarspider cn you please fix this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iarspider , do you remember how you ended up using 9ee817fc61fe3e1b6543a8a16f7bcd8e1f8c331f ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I was just browsing history trying to check a few things, and copy-pasted wrong commit.

Source: git+https://gitlab.desy.de/claus.kleinwort/millepede-ii.git?obj=main/%{tag}&export=%{n}-%{realversion}&output=/%{n}-%{realversion}.tgz
Requires: zlib

%prep
%setup -n %{realversion}
%setup -n %{n}-%{realversion}

%build
make \
Expand Down