Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT master] Updated root to tip of branch master #7601

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Feb 3, 2022

test parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2022

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_3_X/rootmaster.

@cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2022

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed67db/22200/summary.html
COMMIT: 79d3351
CMSSW: CMSSW_12_3_ROOT6_X_2022-02-02-2300/slc7_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7601/22200/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_ROOT6_X_2022-02-02-2300/src/PhysicsTools/Utilities/src/LumiReWeighting.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_ROOT6_X_2022-02-02-2300/src/PhysicsTools/Utilities/src/NumericalIntegration.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_ROOT6_X_2022-02-02-2300/src/PhysicsTools/Utilities/src/SideBandSubtraction.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_ROOT6_X_2022-02-02-2300/src/PhysicsTools/Utilities/src/Variables.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_ROOT6_X_2022-02-02-2300/src/PhysicsTools/Utilities/src/SideBandSubtraction.cc: In member function 'int SideBandSubtract::doGlobalFit()':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_ROOT6_X_2022-02-02-2300/src/PhysicsTools/Utilities/src/SideBandSubtraction.cc:415:41: error: invalid user-defined conversion from 'const char [2]' to 'const RooLinkedList&' [-fpermissive]
  415 |     fit_result = ModelPDF->fitTo(*Data, "r");
      |                                         ^~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/lcg/root/6.27.01-32e433daaf26ecfbe7ab5f59d16dd47a/include/RooLinkedListIter.h:20,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/lcg/root/6.27.01-32e433daaf26ecfbe7ab5f59d16dd47a/include/RooAbsArg.h:26,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/lcg/root/6.27.01-32e433daaf26ecfbe7ab5f59d16dd47a/include/RooAbsReal.h:19,


@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2022

Pull request #7601 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2022

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed67db/22215/summary.html
COMMIT: 7235009
CMSSW: CMSSW_12_3_ROOT6_X_2022-02-03-2300/slc7_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7601/22215/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed67db/22215/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed67db/22215/git-merge-result

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_ROOT6_X_2022-02-03-2300/src/PhysicsTools/Utilities/src/LumiReWeighting.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_ROOT6_X_2022-02-03-2300/src/PhysicsTools/Utilities/src/NumericalIntegration.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_ROOT6_X_2022-02-03-2300/src/PhysicsTools/Utilities/src/SideBandSubtraction.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_ROOT6_X_2022-02-03-2300/src/PhysicsTools/Utilities/src/Variables.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_ROOT6_X_2022-02-03-2300/src/PhysicsTools/Utilities/src/SideBandSubtraction.cc: In member function 'int SideBandSubtract::doGlobalFit()':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_ROOT6_X_2022-02-03-2300/src/PhysicsTools/Utilities/src/SideBandSubtraction.cc:415:41: error: invalid user-defined conversion from 'const char [2]' to 'const RooLinkedList&' [-fpermissive]
  415 |     fit_result = ModelPDF->fitTo(*Data, "r");
      |                                         ^~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/lcg/root/6.27.01-97328fae4bfd55ae2a66857a37c279b6/include/RooLinkedListIter.h:20,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/lcg/root/6.27.01-97328fae4bfd55ae2a66857a37c279b6/include/RooAbsArg.h:26,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/lcg/root/6.27.01-97328fae4bfd55ae2a66857a37c279b6/include/RooAbsReal.h:19,


@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_12_3_ROOT6_X

@smuzaffar smuzaffar merged commit ae63cd4 into cms-sw:IB/CMSSW_12_3_X/rootmaster Feb 7, 2022
@smuzaffar smuzaffar deleted the root-update-master-20220203 branch February 7, 2022 22:09
@guitargeek
Copy link

guitargeek commented Feb 7, 2022

Just for the record if you see these RooFit errors again: cms-sw/cmssw#36903 (comment)

Sorry again for breaking things with new compile-time restrictions 🙂

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed67db/22264/summary.html
COMMIT: 7235009
CMSSW: CMSSW_12_3_ROOT6_X_2022-02-06-0000/slc7_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7601/22264/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed67db/22264/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed67db/22264/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 17359 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3765080
  • DQMHistoTests: Total failures: 42089
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 3722962
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -233.525 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -33.682 KiB GEM/Efficiency
  • DQMHistoSizes: changed ( 11834.0 ): 2.249 KiB SiStrip/MechanicalView
  • Checked 193 log files, 42 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 6 / 45 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants