Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROOT6] Updated root to tip of branch master #7558

Merged
merged 1 commit into from
Jan 21, 2022
Merged

[ROOT6] Updated root to tip of branch master #7558

merged 1 commit into from
Jan 21, 2022

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

test parameters:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_3_X/rootmaster.

@cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar smuzaffar mentioned this pull request Jan 20, 2022
Merged
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a7b41/21843/summary.html
COMMIT: 5f42996
CMSSW: CMSSW_12_3_ROOT6_X_2022-01-19-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7558/21843/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16934 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3464860
  • DQMHistoTests: Total failures: 179305
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3285532
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.816 KiB( 42 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 1.816 KiB SiStrip/MechanicalView
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: found differences in 5 / 42 workflows

@smuzaffar
Copy link
Contributor Author

+externals
Good to go in for ROOT6 master branch

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_3_X/rootmaster IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor Author

lets get this in root6 master IBs

@smuzaffar smuzaffar merged commit 2af2f32 into IB/CMSSW_12_3_X/rootmaster Jan 21, 2022
@smuzaffar smuzaffar deleted the smuzaffar-patch-8 branch January 21, 2022 11:29
@cmsbuild cmsbuild mentioned this pull request May 16, 2022
Merged
@cmsbuild cmsbuild mentioned this pull request Aug 16, 2022
Merged
@cmsbuild cmsbuild mentioned this pull request Jun 7, 2023
Closed
@cmsbuild cmsbuild mentioned this pull request Aug 7, 2023
Merged
@cmsbuild cmsbuild mentioned this pull request Sep 28, 2023
Closed
@cmsbuild cmsbuild mentioned this pull request Oct 23, 2023
Merged
@cmsbuild cmsbuild mentioned this pull request Nov 22, 2023
Merged
@cmsbuild cmsbuild mentioned this pull request Feb 2, 2024
Merged
This was referenced Feb 19, 2024
Closed
Merged
@cmsbuild cmsbuild mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-approved fully-signed orp-pending requires-external tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smuzaffar @cmsbuild