[BuildRules] Added checks for private header usage #7221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test parameters:
|
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_1_X/devel. @cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks. |
|
please test for CMSSW_12_1_DEVEL_X |
|
please test for CMSSW_12_1_DEVEL_X |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28c220/17900/summary.html External BuildI found compilation error when building: >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/8dfdd4f3dd35f187e85c722b237ca0e9/opt/cmssw/slc7_amd64_gcc900/cms/coral/CORAL_2_3_21-8dfdd4f3dd35f187e85c722b237ca0e9/src/LCG/ConnectionService/src/WebCacheControl.cpp /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/gcc/9.3.0/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/8dfdd4f3dd35f187e85c722b237ca0e9/opt/cmssw/slc7_amd64_gcc900/cms/coral/CORAL_2_3_21-8dfdd4f3dd35f187e85c722b237ca0e9/include/LCG -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/boost/1.75.0-dhcijl/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/libuuid/2.34-bcolbf2/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/xerces-c/3.1.3-bcolbf2/include -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++1z -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-deprecated-copy -Wno-unused-parameter -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -fPIC -MMD -MF tmp/slc7_amd64_gcc900/src/LCG/ConnectionService/src/lcg_ConnectionService/WebCacheControl.cpp.d /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/8dfdd4f3dd35f187e85c722b237ca0e9/opt/cmssw/slc7_amd64_gcc900/cms/coral/CORAL_2_3_21-8dfdd4f3dd35f187e85c722b237ca0e9/src/LCG/ConnectionService/src/WebCacheControl.cpp -o tmp/slc7_amd64_gcc900/src/LCG/ConnectionService/src/lcg_ConnectionService/WebCacheControl.cpp.o >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/8dfdd4f3dd35f187e85c722b237ca0e9/opt/cmssw/slc7_amd64_gcc900/cms/coral/CORAL_2_3_21-8dfdd4f3dd35f187e85c722b237ca0e9/src/LCG/ConnectionService/src/module.cpp /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/gcc/9.3.0/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/8dfdd4f3dd35f187e85c722b237ca0e9/opt/cmssw/slc7_amd64_gcc900/cms/coral/CORAL_2_3_21-8dfdd4f3dd35f187e85c722b237ca0e9/include/LCG -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/boost/1.75.0-dhcijl/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/libuuid/2.34-bcolbf2/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/xerces-c/3.1.3-bcolbf2/include -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++1z -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-deprecated-copy -Wno-unused-parameter -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -fPIC -MMD -MF tmp/slc7_amd64_gcc900/src/LCG/ConnectionService/src/lcg_ConnectionService/module.cpp.d /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/8dfdd4f3dd35f187e85c722b237ca0e9/opt/cmssw/slc7_amd64_gcc900/cms/coral/CORAL_2_3_21-8dfdd4f3dd35f187e85c722b237ca0e9/src/LCG/ConnectionService/src/module.cpp -o tmp/slc7_amd64_gcc900/src/LCG/ConnectionService/src/lcg_ConnectionService/module.cpp.o + '[' '' == set ']' error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.oiJrwO (%build) RPM build errors: Macro %rpmbuild_libdir defined but not used within scope Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.oiJrwO (%build) |
|
please test |
|
please test for CMSSW_12_1_DEVEL_X |
1 similar comment
|
please test for CMSSW_12_1_DEVEL_X |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28c220/17917/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this check only generate an error message but does not fail the build process. Once all the cmssw code is clean of such privbate header usage then we can enable this check to fail in the user dev area.
Lets first integrate it in devel IBs to see the side effects