[XROOTD] Update top version 5.3.1

[smuzaffar]

fixes #7179

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

Pull request #7180 was updated.

[smuzaffar]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cbd43/17319/summary.html
COMMIT: b6ae273
CMSSW: CMSSW_12_0_X_2021-07-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7180/17319/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-28-1100/src/Utilities/XrdAdaptor/src/XrdRequest.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-28-1100/src/Utilities/XrdAdaptor/src/XrdRequestManager.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-28-1100/src/Utilities/XrdAdaptor/src/XrdSource.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-28-1100/src/Utilities/XrdAdaptor/src/XrdStatistics.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-28-1100/src/Utilities/XrdAdaptor/src/XrdRequestManager.cc:23:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-28-1100/src/Utilities/XrdAdaptor/src/XrdHostHandler.hh:9:10: fatal error: XrdSys/XrdSysLinuxSemaphore.hh: No such file or directory
    9 | #include "XrdSys/XrdSysLinuxSemaphore.hh"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-28-1100/src/Utilities/XrdAdaptor/src/XrdRequestManager.cc:23:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-28-1100/src/Utilities/XrdAdaptor/src/XrdHostHandler.hh:9:10: fatal error: XrdSys/XrdSysLinuxSemaphore.hh: No such file or directory


[osschar]

@smuzaffar I can give it a try tomorrow, fixing XrdAdaptor and friends. Are the instructions from buildbot above reasonable? I haven't done much cmssw development lately :)

[osschar]

decided to try it anyway, apparently directory 7180 has not been created:

matevz@lxplus7100 ~> ls /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist
7167  7168  7169  7170  7171  7172  7174  7175  7176  7177  7178

[smuzaffar]

ah yes @osschar , in case of build errors we do not upload cmssw area. I will fix bot message for that.
For now you can try this

scram p CMSSW_12_0_X_2021-07-28-1100
cd CMSSW_12_0_X_2021-07-28-1100/
mv config/toolbox/slc7_amd64_gcc900/tools tools.old
cp -r /cvmfs/cms-ci.cern.ch/week1/PR_c3ae2f01/slc7_amd64_gcc900/cms/cmssw-tool-conf/50.0-26030e972e4c6e452a0c6d6969074d6a/tools config/toolbox/slc7_amd64_gcc900/
scram setup
cmsenv
git cms-addpkg Utilities/XrdAdaptor
scram b -j 20

[osschar]

Thank you! Missing XrdSysLinuxSemaphore was actually the only compilation error.

https://github.com/osschar/cmssw/tree/from-CMSSW_12_0_X_2021-07-28-1100

I'm in contact with core xrootd guys to see if I should re-check some other things as well.

When I'm done, what do I make the PR against to make it link to this external update?

[smuzaffar]

@osschar , if changes are needed only for CMSSW then open PR to cmssw repository and then we can test it using "please test with #7180". If changes are also needed for root then we need to open a pr https://github.com/cms-sw/root/tree/cms/v6-22-00-patches%2Fabd79a9716 and then test all of them together

[cmsbuild]

Pull request #7180 was updated.

[osschar]

@smuzaffar apparently my working area setup as you advised me before is no longer viable, IB and tool-confs are both gone, it seems.
I have changes for cms-sw/cmssw#34700 that I'd like to test.
Please help! :)

[smuzaffar]

@osschar , the PR build area is only available for one week that is why the old externals have been deleted from cvmfs. Please try

scram p CMSSW_12_1_X_2021-08-18-1500
cd CMSSW_12_1_X_2021-08-18-1500/
mv config/toolbox/slc7_amd64_gcc900/tools tools.old
cp -r /cvmfs/cms-ci.cern.ch/week1/PR_c3ae2f01/slc7_amd64_gcc900/cms/cmssw-tool-conf/50.0-26030e972e4c6e452a0c6d6969074d6a/tools config/toolbox/slc7_amd64_gcc900/
scram setup
cmsenv
git cms-addpkg Utilities/XrdAdaptor
scram b -j 20

/cvmfs/cms-ci.cern.ch/week1/PR_c3ae2f01/slc7_amd64_gcc900/cms/cmssw-tool-conf/50.0-26030e972e4c6e452a0c6d6969074d6a is newly build cmssw externals

[osschar]

I'm sorry, I can't see directory /cvmfs/cms-ci.cern.ch/week1/PR_c3ae2f01/ ... it's also not in ../week0/ where there are some newer sub-dirs.

I tried to figure out what hash following PR_ is and failed (I was guessing it's a cmsdist short commit id).

[smuzaffar]

ah sorry, please use

/cvmfs/cms-ci.cern.ch/week0/PR_3c452db3/slc7_amd64_gcc900/cms/cmssw-tool-conf/51.0-59a51b1ea7b46a451767770f84e0362b/tools

[smuzaffar]

lets merge it for DEVEL IBs to fully test it