Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade lhapdf to 6.3.0, sets to 6.3.0f #7122

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

mkirsano
Copy link
Contributor

@mkirsano mkirsano commented Jul 12, 2021

Fixes #7097

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.
cms-bot commands are listed here

@mkirsano
Copy link
Contributor Author

Explicit dowloading of pdf sets reduced to one set MSTW2008nlo68cl

@mkirsano
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e75854/16712/summary.html
COMMIT: 74fa74b
CMSSW: CMSSW_12_0_X_2021-07-12-1400/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7122/16712/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2787742
  • DQMHistoTests: Total failures: 861
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2786881
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit bd3dae1 into cms-sw:IB/CMSSW_12_0_X/master Jul 13, 2021
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@agrohsje
Copy link

agrohsje commented Sep 3, 2021

please test
trying to understand the differences observed in 12_0_0_pre4 and pre6

@smuzaffar
Copy link
Contributor

@agrohsje , this PR has been merged. What do you want to achieve by running tests again?

@agrohsje
Copy link

agrohsje commented Sep 3, 2021

There was a gen validation report on Thursday and there is an issue with TTbar in 12_0_0_pre4 vs 12_0_0_pre6. Other processes don't show it. At some point we fixed PDF in gridpacks. I wanted to see which tests show differences here. Tests are already gone.

@agrohsje
Copy link

agrohsje commented Sep 7, 2021

Problem seems related to a weight update in Pythia 8.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update LHAPDF 6.3.0
4 participants