Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another set of python2 tools to be removed #6962

Merged
merged 4 commits into from
Jun 3, 2021

Conversation

davidlange6
Copy link
Contributor

No description provided.

@davidlange6
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2021

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

@davidlange6 , looks like this contains the changes of #6955 too ..right?
Can we drop cryptography too as no packages requires it any more (only pyOpenSSL was using it)

@davidlange6
Copy link
Contributor Author

davidlange6 commented Jun 2, 2021 via email

@davidlange6
Copy link
Contributor Author

I don't find anything that suggests that the cryptography package is important for some use case - I'll drop cryptography when I next update this (or in the next PR in case this one doesn't need updating)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-007cf0/15537/summary.html
COMMIT: d6cadca
CMSSW: CMSSW_12_0_X_2021-06-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6962/15537/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-007cf0/15537/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-007cf0/15537/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2650451
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar merged commit 59a2f5d into cms-sw:IB/CMSSW_12_0_X/master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants