-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPC - remove -mlong-double-64 flag and use the default #6933
Conversation
A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_0_X/master. @cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d0525/15249/summary.html Comparison SummarySummary:
|
please test |
test parameters:
|
please test |
-1 Failed Tests: Build BuildI found compilation error when building: from /scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/GeometryVector/interface/Phi.h:5, from /scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/GeometryVector/test/PhiTest.cc:1: /scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/GeometryVector/test/PhiTest.cc: In instantiation of 'int testSmall() [with valType = float]': /scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/GeometryVector/test/PhiTest.cc:172:24: required from here /scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/GeometryVector/test/PhiTest.cc:39:31: in 'constexpr' expansion of 'angle_units::operators::operator""_pi(1.52999e+1l)' /scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/Math/interface/angle_units.h:14:63: error: '(1.52999e+1l * 3.14159265358979311599796346854419e+0l)' is not a constant expression 14 | constexpr double operator"" _pi(long double x) { return x * piRadians; } | ~~^~~~~~~~~~~ /scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/GeometryVector/test/PhiTest.cc: In instantiation of 'int testSmall() [with valType = double]': /scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/GeometryVector/test/PhiTest.cc:175:25: required from here /scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/GeometryVector/test/PhiTest.cc:39:31: in 'constexpr' expansion of 'angle_units::operators::operator""_pi(1.52999e+1l)' |
a290a82
to
7b46b26
Compare
please test with cms-sw/cmssw#33892 |
Pull request #6933 was updated. |
abort |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test test_PrepareInputDb had ERRORS ---> test test_MpsWorkFlow had ERRORS ---> test DFM_Math had ERRORS ---> test testFWCoreUtilities had ERRORS and more ... |
@smuzaffar cms-sw/cmssw#33892 is merged now we can get this one for the evening IB |
@mrodozov , I would like to test OpenBlas change separately to see if that works for SKYLAKEAVX512_X IBs. Can you please just make a PR with only OpenBLAS update? |
Pull request #6933 was updated. |
I remove the openblas changes. get it as it is ? |
please test for slc7_ppc64le_gcc9 |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test test_PrepareInputDb had ERRORS ---> test test_MpsWorkFlow had ERRORS ---> test DFM_Math had ERRORS ---> test DFM_MathRepr had ERRORS and more ... |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
Compiling externals with the -mlong-double-64 makes their long double types to have only 64 bits size when cmssw long double vars remain 128 using the defaults.
In this case cmssw 128 bits var were passed to clhep compiled with -mlong-double-64