Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiling tools update. #6854

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

gartung
Copy link
Member

@gartung gartung commented Apr 28, 2021

Add toolfile for Google perftools profiler library.
Update libunwind and gpertools version to latest.
Build igprof with internal debug messages enabled by env var.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

gperftools-toolfile.spec Outdated Show resolved Hide resolved
…Update libunwind and gpertools version to latest. Build igprof with internal debug messages enabled by env var.
@gartung gartung force-pushed the gartung-profilers branch from 01721d2 to 0d26bff Compare April 28, 2021 14:48
@cmsbuild
Copy link
Contributor

Pull request #6854 was updated.

@gartung
Copy link
Member Author

gartung commented Apr 28, 2021

please test with cms-sw/cmssw#33566

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4a577/14676/summary.html
COMMIT: 0d26bff
CMSSW: CMSSW_12_0_X_2021-04-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6854/14676/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4a577/14676/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4a577/14676/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877605
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2877581
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

this PR should go in the IB before cms-sw/cmssw#33566

@smuzaffar smuzaffar merged commit 3dfdcc5 into cms-sw:IB/CMSSW_12_0_X/master Apr 29, 2021
@gartung gartung deleted the gartung-profilers branch May 4, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants