-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TBB to 2021.2.0 and use cmake to build #6792
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,31 @@ | ||
### RPM external tbb 2020_U3 | ||
### RPM external tbb v2021.2.0 | ||
|
||
%define tag %{realversion} | ||
%define branch tbb_2020 | ||
%define branch onetbb_2021 | ||
%define github_user oneapi-src | ||
Source: git+https://github.com/%{github_user}/oneTBB.git?obj=%{branch}/%{tag}&export=%{n}-%{realversion}&output=/%{n}-%{realversion}-%{tag}.tgz | ||
%define github_repo oneTBB | ||
Source: git+https://github.com/%{github_user}/%{github_repo}.git?obj=%{branch}/%{tag}&export=%{n}-%{realversion}&output=/%{n}-%{branch}-%{tag}.tgz | ||
Requires: hwloc | ||
BuildRequires: cmake | ||
|
||
%prep | ||
%setup -n %{n}-%{realversion} | ||
|
||
%build | ||
rm -rf %{_builddir}/build | ||
mkdir %{_builddir}/build | ||
|
||
make %{makeprocesses} stdver=c++17 tbb_cpf=1 | ||
cd %{_builddir}/build | ||
cmake ../%{n}-%{realversion} \ | ||
-DCMAKE_BUILD_TYPE=RelWithDebInfo \ | ||
-DCMAKE_INSTALL_PREFIX=%{i} \ | ||
-DCMAKE_INSTALL_LIBDIR=lib \ | ||
-DCMAKE_HWLOC_2_INCLUDE_PATH=$HWLOC_ROOT/include \ | ||
-DCMAKE_HWLOC_2_LIBRARY_PATH=$HWLOC_ROOT/lib/libhwloc.so \ | ||
-DTBB_CPF=ON | ||
|
||
make %{makeprocesses} | ||
|
||
%install | ||
install -d %i/lib | ||
cp -r include %i/include | ||
case %cmsplatf in | ||
osx*) SONAME=dylib ;; | ||
*) SONAME=so ;; | ||
esac | ||
find build -name "*.$SONAME*" -exec cp {} %i/lib \; | ||
ln -s libtbb_preview.${SONAME} %{i}/lib/libtbb.${SONAME} | ||
cmake -DINSTALL_DIR=%{i}/cmake/TBB -DSYSTEM_NAME=Linux -DINC_PATH=%{i}/include -DLIB_PATH=%{i}/lib -P cmake/tbb_config_installer.cmake | ||
cd %{_builddir}/build | ||
make install |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might need to change this to lib64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind. I see you set CMAKE_INSTALL_LIBDIR=lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are having this policy of deliberately keeping the lib instead of lib64