Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump py3-cmsmonitoring to 0.3.4; add it as dependency on wmagentpy3 specs; drop pystack #6714

Merged
merged 4 commits into from
Mar 10, 2021

Conversation

amaltaro
Copy link

@amaltaro amaltaro commented Mar 10, 2021

Fixes dmwm/WMCore#10304
Fixes dmwm/WMCore#10305

Summary of changes (not locally tested) are:

  • bump version of py3-cmsmonitoring from 0.2.4 to 0.3.4 (same as used in production in py2 right now)
  • drop pystack dependency on the wmagentpy3 and wmagentpy3-dev specs
  • replace cmsmonitoring by py3-cmsmonitoring dependency in the wmagentpy3 specs

@muhammadimranfarooqi
Copy link

-1 to fa23b10 on slc7_amd64_gcc630.
Build log can be found here.

@amaltaro
Copy link
Author

It failed because py3-cmsmonitoring 0.5.23 isn't available in pypy:

ERROR: Could not find a version that satisfies the requirement cmsmonitoring==0.5.23 (from versions: 0.0.2, 0.0.3, 0.0.4, 0.0.5, 0.0.6, 0.0.7, 0.0.8, 0.0.9, 0.1.0, 0.1.1, 0.1.2, 0.1.3, 0.1.4, 0.1.6, 0.1.7, 0.1.8, 0.1.9, 0.2.0, 0.2.1, 0.2.2, 0.2.3, 0.2.4, 0.2.5, 0.2.6, 0.2.7, 0.2.8, 0.2.9, 0.3.0, 0.3.1, 0.3.2, 0.3.3, 0.3.4, 0.3.5, 0.3.6, 0.3.7, 0.4.0, 0.4.1, 0.4.2, 0.5.0, 0.5.1)
ERROR: No matching distribution found for cmsmonitoring==0.5.23 

Following a safe route and updating it to the current py2 version, thus 0.3.4 at the moment.

@muhammadimranfarooqi
Copy link

+1 to 96e0327 on slc7_amd64_gcc630.
Build log can be found here.

@amaltaro amaltaro changed the title Bump py3-cmsmonitoring to 0.5.23; add it as dependency on wmagentpy3 specs; drop pystack Bump py3-cmsmonitoring to 0.3.4; add it as dependency on wmagentpy3 specs; drop pystack Mar 10, 2021
@amaltaro
Copy link
Author

That's good enough. Still hard to test these changes because the deployment will still fail with other python2 dependencies.

@vkuznet no need to do it right now, but when it's convenient to you, could you please update to pypi the latest cmsmonitoring version? Especially: 0.5.23

@muhammadimranfarooqi
Copy link

+1 to 259ec5e on slc7_amd64_gcc630.
Build log can be found here.

@amaltaro
Copy link
Author

Given that this PR has no impact in CMSWEB services nor in any other packages, I'm merging it.

@amaltaro
Copy link
Author

merge

@cmsbuild cmsbuild merged commit 30fc345 into cms-sw:comp_gcc630 Mar 10, 2021
@cmsbuild
Copy link
Contributor

Command merge acknowledged.

@vkuznet
Copy link
Contributor

vkuznet commented Mar 10, 2021

Alan, since you asked. Event though we have recent tags, as you noticed 0.5.23, in CMSMonitoring repo, all of them reflects changes to Go based code. The python counterpart did not change much at all. I think we should make a separation of repo between python and Go based codes to avoid confusion in tagged versions.

@vkuznet
Copy link
Contributor

vkuznet commented Mar 12, 2021

@amaltaro I added new PR #6726 which brings new cms-monitoring version. I decoupled python and go code in CMSMonitoring repo and python will use explicit versions (once we'll change the codebase), and do not use git tag (which are used now only for go based changes.

Please review the PR and feel free to adopt it in python codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants