-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump py3-cmsmonitoring to 0.3.4; add it as dependency on wmagentpy3 specs; drop pystack #6714
Conversation
It failed because py3-cmsmonitoring 0.5.23 isn't available in pypy:
Following a safe route and updating it to the current py2 version, thus |
That's good enough. Still hard to test these changes because the deployment will still fail with other python2 dependencies. @vkuznet no need to do it right now, but when it's convenient to you, could you please update to pypi the latest cmsmonitoring version? Especially: |
Given that this PR has no impact in CMSWEB services nor in any other packages, I'm merging it. |
merge |
Command merge acknowledged. |
Alan, since you asked. Event though we have recent tags, as you noticed 0.5.23, in CMSMonitoring repo, all of them reflects changes to Go based code. The python counterpart did not change much at all. I think we should make a separation of repo between python and Go based codes to avoid confusion in tagged versions. |
@amaltaro I added new PR #6726 which brings new cms-monitoring version. I decoupled python and go code in CMSMonitoring repo and python will use explicit versions (once we'll change the codebase), and do not use git tag (which are used now only for go based changes. Please review the PR and feel free to adopt it in python codebase. |
Fixes dmwm/WMCore#10304
Fixes dmwm/WMCore#10305
Summary of changes (not locally tested) are:
pystack
dependency on the wmagentpy3 and wmagentpy3-dev specscmsmonitoring
bypy3-cmsmonitoring
dependency in the wmagentpy3 specs