Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root to tip of branch master #6631

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Feb 9, 2021

check root master against existing tbb

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2021

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_3_X/rootmaster.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

mrodozov commented Feb 9, 2021

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d8ee6/12807/summary.html
COMMIT: b3af4f3
CMSSW: CMSSW_11_3_ROOT6_X_2021-02-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6631/12807/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test_MuonGeometryDBConverter had ERRORS
---> test test_PixelBaryCentreTool had ERRORS
---> test CalibCalorimetryEcalLaserSortingRunStreamer had ERRORS
---> test testAlignmentOfflineValidation had ERRORS
and more ...

RelVals

----- Begin Fatal Exception 10-Feb-2021 03:30:49 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type InitRootHandlers
   Additional Info:
      [a] Fatal Root Error: @SUB=RTaskArenaWrapper
tbb::global_control is active, limiting the number of parallel workersfrom this task arena available for execution.

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 10-Feb-2021 03:30:50 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type InitRootHandlers
   Additional Info:
      [a] Fatal Root Error: @SUB=RTaskArenaWrapper
tbb::global_control is active, limiting the number of parallel workersfrom this task arena available for execution.

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 10-Feb-2021 03:30:50 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type InitRootHandlers
   Additional Info:
      [a] Fatal Root Error: @SUB=RTaskArenaWrapper
tbb::global_control is active, limiting the number of parallel workersfrom this task arena available for execution.

----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

AddOn Tests

----- Begin Fatal Exception 10-Feb-2021 03:28:44 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type InitRootHandlers
   Additional Info:
      [a] Fatal Root Error: @SUB=RTaskArenaWrapper
tbb::global_control is active, limiting the number of parallel workersfrom this task arena available for execution.

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 10-Feb-2021 03:28:03 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type InitRootHandlers
   Additional Info:
      [a] Fatal Root Error: @SUB=RTaskArenaWrapper
tbb::global_control is active, limiting the number of parallel workersfrom this task arena available for execution.

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 10-Feb-2021 03:28:03 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type InitRootHandlers
   Additional Info:
      [a] Fatal Root Error: @SUB=RTaskArenaWrapper
tbb::global_control is active, limiting the number of parallel workersfrom this task arena available for execution.

----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@mrodozov
Copy link
Contributor Author

please test with cms-sw/cmssw#32782

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d8ee6/12816/summary.html
COMMIT: b3af4f3
CMSSW: CMSSW_11_3_X_2021-02-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6631/12816/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testSchemaEvolution had ERRORS

RelVals-INPUT

  • 10824.52110824.521_TTbar_13+2018_Patatrack_HCALOnlyCPU+TTbar_13TeV_TuneCUETP8M1_GenSimINPUT+Digi+RecoFakeHLT+HARVESTFakeHLT/step2_TTbar_13+2018_Patatrack_HCALOnlyCPU+TTbar_13TeV_TuneCUETP8M1_GenSimINPUT+Digi+RecoFakeHLT+HARVESTFakeHLT.log

Comparison Summary

Summary:

  • You potentially added 8128651 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2751765
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2751733
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

mrodozov added a commit to mrodozov/cmssw that referenced this pull request Feb 12, 2021
ROOT has changed their class version for TF1 changed in master from 10 to 11 in :
root-project/root#7035
I've requested a backport for the change to 6-22 root-project/root#7193
so we can have them consistent and have 
cms-sw/cmsdist#6631 integrated
Note that there is another such class version change in the same PR for TFormula from 12 to 13
and please let me know if anything else follows from the proposed changes (like should we change TFormula version somewhere)
@cmsbuild
Copy link
Contributor

Pull request #6631 was updated.

@mrodozov
Copy link
Contributor Author

please test with cms-sw/cmssw#32890

get latest from master and test it before merging into ROOT master
@cmsbuild
Copy link
Contributor

Pull request #6631 was updated.

@mrodozov
Copy link
Contributor Author

please test with cms-sw/cmssw#32890

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d8ee6/12947/summary.html
COMMIT: a944d31
CMSSW: CMSSW_11_3_X_2021-02-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6631/12947/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 8146400 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2750951
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants