Updated root to tip of branch master

[mrodozov]

please test

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_3_X/rootmaster.

@smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[mrodozov]

please test

[cmsbuild]

-1

CMSSW: CMSSW_11_3_ROOT6_X_2020-12-04-2300
SCRAM_ARCH: slc7_amd64_gcc900
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34a072/11391/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2020-12-04-2300/src/RecoLocalCalo/HcalRecAlgos/src/MahiFit.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2020-12-04-2300/src/RecoLocalCalo/HcalRecAlgos/src/PedestalSub.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2020-12-04-2300/src/RecoLocalCalo/HcalRecAlgos/src/PulseShapeFitOOTPileupCorrection.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2020-12-04-2300/src/RecoLocalCalo/HcalRecAlgos/src/PulseShapeFunctor.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2020-12-04-2300/src/RecoLocalCalo/HcalRecAlgos/src/HybridMinimizer.cc: In member function 'virtual bool PSFitter::HybridMinimizer::SetVariable(unsigned int, const string&, double, double)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2020-12-04-2300/src/RecoLocalCalo/HcalRecAlgos/src/HybridMinimizer.cc:172:7: error: 'MN_INFO_MSG2' was not declared in this scope; did you mean 'MATH_INFO_MSG'?
  172 |       MN_INFO_MSG2("HybridMinimizer::SetVariable", txtmsg);
      |       ^~~~~~~~~~~~
      |       MATH_INFO_MSG
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2020-12-04-2300/src/RecoLocalCalo/HcalRecAlgos/src/HybridMinimizer.cc:180:7: error: 'MN_INFO_MSG2' was not declared in this scope; did you mean 'MATH_INFO_MSG'?
  180 |       MN_INFO_MSG2("HybridMinimizer::SetVariable", txtmsg);


[mrodozov]

ROOT changed Minuit logging here in master:
root-project/root#6705
and it's only in master, which means either we ask them to put it in 6-22 and fix it once or device something else.
To use the new logging nearly but not exactly straightforward so authors of
RecoLocalCalo/HcalRecAlgos should have to setup the MnPrint:: SetLevel -> Verbose and some other printing

[davidlange6]

I realize that we have copied and modified some root code here.. The trouble with that being that now we should in theory re-copy and re-modify it..

Practically some easy alternatives are
a) use the cms message logger for printouts (advantage - will behave like other cms code)
b) add the ifdefs for these - eg, from here:
https://github.com/root-project/root/pull/6705/files#diff-0dee475476c5a425f99aedd676a201955d915d7622abcfe256a2d1fcccc36872L105

[mrodozov]

I substituted all calls with LogInfo since they were just printouts anyway
cms-sw/cmssw#32440

[cmsbuild]

Pull request #6487 was updated.

[mrodozov]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34a072/11816/summary.html
CMSSW: CMSSW_11_3_ROOT6_X_2020-12-18-2300/slc7_amd64_gcc900

DAS Queries failed

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2716967
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2716932
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 153 log files, 37 edm output root files, 36 DQM output files