Update rivet-toolfile.spec

[mseidel42]

For unknown reason, the Rivet paths need to be set more carefully now.

Fixes the following problem:

cmsRun: RivetYODA.cc:52: typename T::Ptr Rivet::Wrapper<T>::active() const [with T = YODA::Counter; typename T::Ptr = std::shared_ptr<YODA::Counter>]: Assertion `false && "No activ e pointer set. Was this object booked in init()?"' failed.

How to reproduce the problem:
CMSSW_11_0_0_pre7/gcc700 -> rivet --list-analyses working
CMSSW_11_0_0_pre7/gcc820 (and newer) -> not working

[cmsbuild]

A new Pull Request was created by @intrepid42 (Markus Seidel) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4489/console Started: 2020/02/04 10:46

[cmsbuild]

+1
Tested at: 401bac2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b6616/4489/summary.html
CMSSW: CMSSW_11_1_X_2020-02-03-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[mrodozov]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b6616/4489/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697068
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2696721
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[smuzaffar]

@intrepid42 , can you please a unit tests to in cmssw to make sure that rivet --list-analyses runs. A simple unit test like

<test name="test-revet-list" command="rivet --list-analyses"/>

in GeneratorInterface/RivetInterface/test/BuildFile.xml should be enough.

[mseidel42]

@smuzaffar Yes, I would be happy to add that. Is it also possible to do a cmsRun on an example config? We would just need to make sure that it does not crash.

[mseidel42]

Instead could we check that one of the analyses is actually loaded?
The command would be rivet --list-analyses | grep MC_GENERIC.
Can I put that in the xml? How can I test it locally?

[smuzaffar]

for bit complex things , it is better to add a shell script and run it e.g

<test name="test-revet-list" command="test-revet-list.sh"/>

in side the script you can run cmsRun and/or rivet

[smuzaffar]

in order to test, just run scram build runtests

[mseidel42]

Thank you, that works.

It would be nice to test GenParticles2HepMCConverter also.
Do you know if there are any persistent AODSIM or MINIAODSIM files that we can use for that?

[smuzaffar]

@intrepid42 I have no idea.
@fabiocos , @silviodonato do you have any idea of any persistent AODSIM or MINIAODSIM?

[mseidel42]

Ah never mind, I think I can generate some Pythia events, convert to genParticles, convert back to HepMC, and use that as input for Rivet, to test the whole chain.