Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9_4_X] Update data-RecoBTag-Combined.spec #4549

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Dec 4, 2018

Backport of #4540

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2018

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_9_4_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mrodozov mrodozov changed the title Update data-RecoBTag-Combined.spec [9_4_X] Update data-RecoBTag-Combined.spec Dec 4, 2018
@slava77
Copy link
Contributor

slava77 commented Dec 4, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31979/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4549/31979/summary.html

The workflows 1001.0, 1000.0, 140.53, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 113
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721218
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@slava77
Copy link
Contributor

slava77 commented Dec 4, 2018

Reco comparison results: 0 differences found in the comparisons

this confirms that this PR can be merged by itself now, before cms-sw/cmssw#25371 is merged

@smuzaffar
Copy link
Contributor

+externals

this resolves #4537

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_4_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#25371
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32051/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#25371
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32052/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 10, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#25371
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32085/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 4b73962 into IB/CMSSW_9_4_X/gcc630 Dec 13, 2018
@smuzaffar smuzaffar deleted the backport-data-RecoBTag-Combined-94Xgcc63 branch December 13, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants