Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow profiling workflow(s) to be specified with PR multiline comment #1545

Merged
merged 5 commits into from
Apr 29, 2021

Conversation

gartung
Copy link
Member

@gartung gartung commented Apr 29, 2021

Adding multiline comment

test parameters:
workflows_profiling=11834.21

should override the default
PR_TEST_MATRIX_EXTRAS_PROFILING=23434.21,11834.21

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for branch master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented Apr 29, 2021

@smuzaffar

process_pr.py Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

Pull request #1545 was updated.

@slava77
Copy link
Contributor

slava77 commented Apr 29, 2021

should this PR still be restricted to just what's possible/tested in the context of https://github.com/cms-cmpwg/profiling/blob/master/Gen_tool/Gen.sh and what follow from it (4 steps etc) ?

I'm guessing that I can't ask for some random wf, like 136.88811 which we often use for data PAT/miniAOD testing.

@smuzaffar
Copy link
Contributor

@slava77 , yes you can not ask for any random workflow. Workflow should the one defined here https://github.com/cms-sw/cms-bot/blob/master/cmssw-pr-test-config#L3

@cmsbuild
Copy link
Contributor

Pull request #1545 was updated.

@smuzaffar
Copy link
Contributor

@gartung , can we trigger an IB profiling job if PR profiling workflow is not part of https://github.com/cms-sw/cms-bot/blob/master/cmssw-pr-test-config#L3 ? I think from the pr-schedule-tests we can check this and ask jenkins to start such job

@gartung
Copy link
Member Author

gartung commented Apr 29, 2021

The profiling script expects a 4 step simulation workflow with simulation, pileup mixing, reconstruction, and miniAOD production. I am trying to figure out a way to validate the workflow against PR_TEST_MATRIX_EXTRAS_PROFILING

@cmsbuild
Copy link
Contributor

Pull request #1545 was updated.

@cmsbuild
Copy link
Contributor

Pull request #1545 was updated.

@gartung
Copy link
Member Author

gartung commented Apr 29, 2021

enable profiling

@gartung
Copy link
Member Author

gartung commented Apr 29, 2021

test parameters:
workflows_profiling=11834.21

@gartung
Copy link
Member Author

gartung commented Apr 29, 2021

please test

@gartung
Copy link
Member Author

gartung commented Apr 29, 2021

abort

@smuzaffar
Copy link
Contributor

@gartung There is no way we can test this as it is. Either we merge it or make two PRs one for cms-bot so that it can properly pass the new profiling parameter and other to use it in profiling job.
I suggest to just merge it :-)

@smuzaffar smuzaffar merged commit 90b0a9d into cms-sw:master Apr 29, 2021
@gartung
Copy link
Member Author

gartung commented Apr 29, 2021

OK Thanks.

@gartung gartung deleted the gartung-pr-profiling-workflows branch April 29, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants