Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even-odd training-eval selection. Trainings.yaml linked #16

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

ValVau
Copy link
Contributor

@ValVau ValVau commented Oct 18, 2024

Added trainings.yaml link into the code. Training of BDT on even events and evaluation on odd events added

Copy link
Member

@andreypz andreypz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look fine to me.
Please address the comments, and resolve conflicts.

Also, I think you have the model.txt and model_DY.txt files in the root directory of the code which are not longer needed. If that's the case, could you remove those files from the repo.

cfg_VHcc_WLNu.py Outdated Show resolved Hide resolved
cfg_VHcc_ZLL.py Outdated Show resolved Hide resolved
@ValVau
Copy link
Contributor Author

ValVau commented Oct 21, 2024

Added requested changes. Waiting for further comments/ merge

Copy link
Member

@andreypz andreypz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check again.

And what about my comment on the model.txt files?

cfg_VHcc_ZLL.py Outdated Show resolved Hide resolved
@ValVau
Copy link
Contributor Author

ValVau commented Oct 21, 2024

Please, have a look at latest changes

@andreypz andreypz merged commit abf28f1 into cms-rwth:main Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants