Make the the size of the binner (HistoContainer) settable at run time #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwyzard
reviewed
Dec 6, 2020
| constexpr I const* data() const { return m_v; } | ||
|
|
||
| private: | ||
| I* m_v; |
There was a problem hiding this comment.
would it make sense to use
Suggested change
| I* m_v; | |
| std::unique_ptr<I[]> m_v; |
to handle the ownership of the memory ?
There was a problem hiding this comment.
it is external storage. This class is allocated on the GPU!
Validation summaryReference release CMSSW_11_2_0_pre10 at 6c149b2 Validation plots/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW
Validation plots (CPU vs GPU)/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW
Throughput plots/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53
logs and
|
This was referenced Dec 14, 2020
fwyzard
reviewed
Dec 14, 2020
Comment on lines
46
to
+47
| static constexpr uint32_t n16 = 4; | ||
| static constexpr uint32_t n32 = 9; | ||
| static constexpr uint32_t n32 = 10; |
There was a problem hiding this comment.
should be pretty obvious from the code where it is used.
They are of course the number of elements with size 16 and size 32 respectively.
I will add a comment.
fwyzard
reviewed
Dec 14, 2020
| @@ -101,11 +103,15 @@ TrackingRecHit2DHeterogeneous<Traits>::TrackingRecHit2DHeterogeneous(uint32_t nH | |||
| m_store32 = Traits::template make_device_unique<float[]>(nHits * n32 + 11, stream); | |||
There was a problem hiding this comment.
as suggested by @slava77 here, could you clarify if nHits * n32 + 11 should be nHits * n32 + phase1PixelTopology::numberOfLayers + 1 ?
Suggested change
| m_store32 = Traits::template make_device_unique<float[]>(nHits * n32 + 11, stream); | |
| m_store32 = Traits::template make_device_unique<float[]>(nHits * n32 + phase1PixelTopology::numberOfLayers + 1, stream); |
|
I can remove all occurrences of MaxNumberOfHits MaxNumberOfClusters now or later. |
|
@fwyzard: could you please |
|
Rebased onto CMSSW_11_3_X and moved to cms-sw#33371 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is "step1&2" and makes LocalReco independent from the size of the event and tuple-making independent of the number of hits.
Some of the containers used by the CA will remain of fixed size (cannot be extended during the pattern recognition).
In a third step phase1 and phase2 will be still kept separate (fixed number of modules, separate geometries etc)
even if fully configurable at runtime.
tested. no regression. even timing seems ok.