ECAL rechit fix for fill description #504

amassiro · 2020-07-10T15:38:30Z

As required by PR #502
on top of that PR.
Fix of the fill description for ECAL rechit

… is relinquishable

…topic

fwyzard · 2020-07-12T09:32:19Z

Validation summary

Reference release CMSSW_11_1_0_pre8 at 070cb52c6f53
Development branch cms-patatrack/CMSSW_11_1_X_Patatrack at 449d1f0
Testing PRs:

Validation plots

/RelValTTbar_14TeV/CMSSW_11_0_0_patch1-PU_110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflow 11634.5
tracking validation plots and summary for workflow 11634.501
tracking validation plots and summary for workflow 11634.502

/RelValZMM_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflow 11634.5
tracking validation plots and summary for workflow 11634.501
tracking validation plots and summary for workflow 11634.502

/RelValZEE_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflow 11634.5
tracking validation plots and summary for workflow 11634.501
tracking validation plots and summary for workflow 11634.502

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

logs and `nvprof`/`nvvp` profiles

/RelValTTbar_14TeV/CMSSW_11_0_0_patch1-PU_110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

reference release, workflow 11634.5
- ✔️ step3.py: log
development release, workflow 11634.5
- ✔️ step3.py: log
development release, workflow 11634.501
- ✔️ step3.py: log
development release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 11634.511
- ✔️ step3.py: log
development release, workflow 11634.512
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 11634.521
- ✔️ step3.py: log
development release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 136.885502
development release, workflow 136.885512
development release, workflow 136.885522
testing release, workflow 11634.5
- ✔️ step3.py: log
testing release, workflow 11634.501
- ✔️ step3.py: log
testing release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 11634.511
- ✔️ step3.py: log
testing release, workflow 11634.512
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 11634.521
- ✔️ step3.py: log
testing release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 136.885502
testing release, workflow 136.885512
testing release, workflow 136.885522

/RelValZMM_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

reference release, workflow 11634.5
- ✔️ step3.py: log
development release, workflow 11634.5
- ✔️ step3.py: log
development release, workflow 11634.501
- ✔️ step3.py: log
development release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 11634.511
- ✔️ step3.py: log
development release, workflow 11634.512
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 11634.521
- ✔️ step3.py: log
development release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 136.885502
development release, workflow 136.885512
development release, workflow 136.885522
testing release, workflow 11634.5
- ✔️ step3.py: log
testing release, workflow 11634.501
- ✔️ step3.py: log
testing release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 11634.511
- ✔️ step3.py: log
testing release, workflow 11634.512
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 11634.521
- ✔️ step3.py: log
testing release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 136.885502
testing release, workflow 136.885512
testing release, workflow 136.885522

/RelValZEE_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

reference release, workflow 11634.5
- ✔️ step3.py: log
development release, workflow 11634.5
- ✔️ step3.py: log
development release, workflow 11634.501
- ✔️ step3.py: log
development release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 11634.511
- ✔️ step3.py: log
development release, workflow 11634.512
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 11634.521
- ✔️ step3.py: log
development release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 136.885502
development release, workflow 136.885512
development release, workflow 136.885522
testing release, workflow 11634.5
- ✔️ step3.py: log
testing release, workflow 11634.501
- ✔️ step3.py: log
testing release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 11634.511
- ✔️ step3.py: log
testing release, workflow 11634.512
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 11634.521
- ✔️ step3.py: log
testing release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 136.885502
testing release, workflow 136.885512
testing release, workflow 136.885522

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/d6aa71b36fcbb90272ad535da7a800b420cdd25e/log .

fwyzard · 2020-07-12T12:27:29Z

Looks like almost all workflows are finally working.

The only problem is the ECAL-only workflow running on data, 136.885512.
The errors don't show up in the report (need to fix the validation script), but they are the reason the ECAL profiling is missing:

----- Begin Fatal Exception 12-Jul-2020 12:12:55 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 323775 lumi: 53 event: 32482201 stream: 6
   [1] Prefetching for module EcalDQMonitorTask/'ecalMonitorTaskEcalOnly'
   [2] Prefetching for module EcalRecHitConvertGPU2CPUFormat/'ecalRecHit'
   [3] Prefetching for module EcalCPURecHitProducer/'ecalRecHitSoA'
   [4] Prefetching for module EcalRecHitProducerGPU/'ecalRecHitGPU'
   [5] Calling method for module EcalUncalibRecHitProducerGPU/'ecalMultiFitUncalibRecHitGPU'
Exception Message:
No "EcalPedestalsRcd" record found in the EventSetup.n
 The Record is delivered by an ESSource or ESProducer but there is no valid IOV for the synchronizatio value.
 Please check
   a) if the synchronization value is reasonable and report to the hypernews if it is not.
   b) else check that all ESSources have been properly configured.
----- End Fatal Exception -------------------------------------------------

However, they happen both with and without these PRs, so they can be addressed separately.

…ixpr-502

Fix fillDescriptions() for EcalRecHitParametersGPUESProducer.

vkhristenko and others added 17 commits June 19, 2020 12:46

make scratch use caching alloc

9ca193e

use caching allocator for input cpu

c7f9392

using allocators for EventHFilter/HcalRawToDigi

a84d731

hcal/mahi/gpu switch to new input and use allocator for scratch

d05f147

hcal/mahi/gpu move pulse offsets to use esproducer and all dev memory…

8ee109b

… is relinquishable

renaming HcalCommon -> CaloCommon and adapting all the deps

222ff2b

ecal/decoding use device allocators

4f6061a

ecal/reco move to make input/output use dev allocators with caching

bdae637

cleaning/fixing

0bea689

ecal/reco movign scratch to use allocators

43232b8

adding a new condition which is a configuration

415e915

ecal multifit works with dev caching allocators

5cb25ae

ecal rec hit making config use caching allocator

8c25658

undef ARRANGE

2590b9a

remove not needed

f4fd5bc

Merged multigpu_hcal_ecal from repository vkhristenko with cms-merge-…

f79e031

…topic

fix for ecalrehit and new handling of the configuration

4bc7f8d

amassiro mentioned this pull request Jul 10, 2020

Update ECAL and HCAL reconstruction to run on multple GPUs #502

Merged

removal unused code, already commented out

92974cf

fwyzard added the ECAL ECAL-related developments label Jul 11, 2020

This comment has been minimized.

Sign in to view

fwyzard added 2 commits July 11, 2020 19:16

Add missing ecalRecHitParametersGPUESProducer

f5747cf

Add missing ecalMultifitParametersGPUESProducer

67f894f

This comment has been minimized.

Sign in to view

fwyzard added the HCAL HCAL-related developments label Jul 11, 2020

fwyzard added 3 commits July 12, 2020 14:50

Merge branch 'CMSSW_11_1_X_Patatrack' into amassiro-ecal-rechit-gpu-f…

5ea37f6

…ixpr-502

Apply code formatting

7e7a043

Apply code formatting

8bad99f

fwyzard merged commit 8815b9e into cms-patatrack:CMSSW_11_1_X_Patatrack Jul 12, 2020

fwyzard pushed a commit that referenced this pull request Jul 12, 2020

Update ECAL and HCAL reconstruction to run on multple GPUs [3/3] (#504)

b6e7d1b

Fix fillDescriptions() for EcalRecHitParametersGPUESProducer.

fwyzard pushed a commit that referenced this pull request Oct 7, 2020

Update ECAL and HCAL reconstruction to run on multple GPUs [3/3] (#504)

bd3f24c

Fix fillDescriptions() for EcalRecHitParametersGPUESProducer.

fwyzard pushed a commit that referenced this pull request Oct 8, 2020

Update ECAL and HCAL reconstruction to run on multple GPUs [3/3] (#504)

9fa31d1

Fix fillDescriptions() for EcalRecHitParametersGPUESProducer.

fwyzard pushed a commit that referenced this pull request Oct 8, 2020

Update ECAL and HCAL reconstruction to run on multple GPUs [3/3] (#504)

b5ca231

Fix fillDescriptions() for EcalRecHitParametersGPUESProducer.

fwyzard mentioned this pull request Oct 8, 2020

Patatrack integration - ECAL local reconstruction (7/N) cms-sw/cmssw#31719

Merged

fwyzard pushed a commit that referenced this pull request Oct 19, 2020

Update ECAL and HCAL reconstruction to run on multple GPUs [3/3] (#504)

e9fe8a3

Fix fillDescriptions() for EcalRecHitParametersGPUESProducer.

fwyzard pushed a commit that referenced this pull request Nov 9, 2020

Update ECAL and HCAL reconstruction to run on multple GPUs [3/3] (#504)

080466c

Fix fillDescriptions() for EcalRecHitParametersGPUESProducer.

fwyzard pushed a commit that referenced this pull request Nov 12, 2020

Update ECAL and HCAL reconstruction to run on multple GPUs [3/3] (#504)

0dd0a38

Fix fillDescriptions() for EcalRecHitParametersGPUESProducer.

fwyzard pushed a commit that referenced this pull request Nov 16, 2020

Update ECAL and HCAL reconstruction to run on multple GPUs [3/3] (#504)

67d2d8a

Fix fillDescriptions() for EcalRecHitParametersGPUESProducer.

fwyzard added a commit that referenced this pull request Nov 26, 2020

Update ECAL and HCAL reconstruction to run on multple GPUs [3/3] (#504)

57d43de

Fix fillDescriptions() for EcalRecHitParametersGPUESProducer.

fwyzard added a commit that referenced this pull request Nov 28, 2020

Update ECAL and HCAL reconstruction to run on multple GPUs [3/3] (#504)

7a190aa

Fix fillDescriptions() for EcalRecHitParametersGPUESProducer.

fwyzard pushed a commit that referenced this pull request Dec 25, 2020

Update ECAL and HCAL reconstruction to run on multple GPUs [3/3] (#504)

a744300

Fix fillDescriptions() for EcalRecHitParametersGPUESProducer.

fwyzard added a commit that referenced this pull request Dec 26, 2020

Update ECAL and HCAL reconstruction to run on multple GPUs [3/3] (#504)

a2ae18f

Fix fillDescriptions() for EcalRecHitParametersGPUESProducer.

fwyzard pushed a commit that referenced this pull request Dec 29, 2020

Update ECAL and HCAL reconstruction to run on multple GPUs [3/3] (#504)

2a384fa

Fix fillDescriptions() for EcalRecHitParametersGPUESProducer.

fwyzard pushed a commit that referenced this pull request Dec 29, 2020

Update ECAL and HCAL reconstruction to run on multple GPUs [3/3] (#504)

d9d7dc0

Fix fillDescriptions() for EcalRecHitParametersGPUESProducer.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ECAL rechit fix for fill description #504

ECAL rechit fix for fill description #504

amassiro commented Jul 10, 2020

This comment has been minimized.

This comment has been minimized.

fwyzard commented Jul 12, 2020 •

edited

Loading

fwyzard commented Jul 12, 2020

ECAL rechit fix for fill description #504

ECAL rechit fix for fill description #504

Conversation

amassiro commented Jul 10, 2020

This comment has been minimized.

This comment has been minimized.

fwyzard commented Jul 12, 2020 • edited Loading

Validation summary

Validation plots

/RelValTTbar_14TeV/CMSSW_11_0_0_patch1-PU_110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_0_0_patch1-PU_110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

Logs

fwyzard commented Jul 12, 2020

fwyzard commented Jul 12, 2020 •

edited

Loading

logs and `nvprof`/`nvvp` profiles