Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some GPU- and non-GPU-related pixel tracking code #49

Merged
merged 4 commits into from
May 23, 2018
Merged

Clean up some GPU- and non-GPU-related pixel tracking code #49

merged 4 commits into from
May 23, 2018

Conversation

fwyzard
Copy link

@fwyzard fwyzard commented May 23, 2018

Clean up SealModule.cc and BuildFile.xml, remove some unused classes, and rename RawToDigiGPU to SiPixelRawToDigiGPUKernel

@cmsbot
Copy link

cmsbot commented May 23, 2018

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_10_2_X_Patatrack.

It involves the following packages:

EventFilter/SiPixelRawToDigi
RecoLocalTracker/SiPixelRecHits

@cmsbot, @fwyzard can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

makortel
makortel approved these changes May 23, 2018
View reviewed changes
Copy link

@makortel makortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I would only raise a discussion whether we should start using .cuh extension for "CUDA headers" elsewhere as well, or stick with .h.

EventFilter/SiPixelRawToDigi/plugins/SiPixelRawToDigiGPUKernel.cuh Outdated
const uint32_t LINK_bits_l1 = 6;
const uint32_t ROC_bits_l1 = 5;
const uint32_t COL_bits_l1 = 6;
const uint32_t ROW_bits_l1 = 7;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be in a namespace to not pollute the global namespace with them?

(the question is more for the existing code than this PR though)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Also, they are possibly duplicated somewhere else.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for the namespace name ?

@fwyzard
Copy link
Author

fwyzard commented May 23, 2018

I don't mind too much if we use .h or .cuh ... the reason I picked .cuh is because I saw it in some samples, and I discovered that VI would highlight the CUDA part :-)

@fwyzard
Copy link
Author

fwyzard commented May 23, 2018

makeTrackValidationPlots.py plots

/RelValTTbar_13/CMSSW_10_2_0_pre2-PU25ns_101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_0_pre2-101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

DQM GUI plots

/RelValTTbar_13/CMSSW_10_2_0_pre2-PU25ns_101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_0_pre2-101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

nvprof/nvvp profiles

/RelValTTbar_13/CMSSW_10_2_0_pre2-PU25ns_101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

  • reference profile for workflow 10824.5
  • development profile for workflow 10824.5
  • development profile for workflow 10824.8
  • development profile for workflow 10824.7
  • testing profile for workflow 10824.5
  • testing profile for workflow 10824.8
  • testing profile for workflow 10824.7

/RelValZMM_13/CMSSW_10_2_0_pre2-101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

  • reference profile for workflow 10824.5
  • development profile for workflow 10824.5
  • development profile for workflow 10824.8
  • development profile for workflow 10824.7
  • testing profile for workflow 10824.5
  • testing profile for workflow 10824.8
  • testing profile for workflow 10824.7

Logs

The full log is available at https://fwyzard.web.cern.ch/fwyzard/patatrack/pulls/8da1230520fb4750bd5424d5a004ab93eae68d7c/log .

@fwyzard fwyzard force-pushed the tracking_code_cleanup branch from 399f593 to 25d9018 Compare May 23, 2018 12:26
@cmsbot
Copy link

cmsbot commented May 23, 2018

Pull request #49 was updated. @cmsbot, @fwyzard can you please check and sign again.

@fwyzard fwyzard force-pushed the tracking_code_cleanup branch from 25d9018 to ffd8ccd Compare May 23, 2018 12:30
@cmsbot
Copy link

cmsbot commented May 23, 2018

Pull request #49 was updated. @cmsbot, @fwyzard can you please check and sign again.

@fwyzard
Copy link
Author

fwyzard commented May 23, 2018

Renamed form .cuh to .h

@cmsbot
Copy link

cmsbot commented May 23, 2018

Pull request #49 was updated. @cmsbot, @fwyzard can you please check and sign again.

@makortel
Copy link

makortel commented May 23, 2018 •
edited
Loading

Last commit looks ok, thanks.

@fwyzard
Copy link
Author

fwyzard commented May 23, 2018

makeTrackValidationPlots.py plots

/RelValTTbar_13/CMSSW_10_2_0_pre2-PU25ns_101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_0_pre2-101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

DQM GUI plots

/RelValTTbar_13/CMSSW_10_2_0_pre2-PU25ns_101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_0_pre2-101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

nvprof/nvvp profiles

/RelValTTbar_13/CMSSW_10_2_0_pre2-PU25ns_101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

  • reference profile for workflow 10824.5
  • development profile for workflow 10824.5
  • development profile for workflow 10824.8
  • development profile for workflow 10824.7
  • testing profile for workflow 10824.5
  • testing profile for workflow 10824.8
  • testing profile for workflow 10824.7

/RelValZMM_13/CMSSW_10_2_0_pre2-101X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

  • reference profile for workflow 10824.5
  • development profile for workflow 10824.5
  • development profile for workflow 10824.8
  • development profile for workflow 10824.7
  • testing profile for workflow 10824.5
  • testing profile for workflow 10824.8
  • testing profile for workflow 10824.7

Logs

The full log is available at https://fwyzard.web.cern.ch/fwyzard/patatrack/pulls/a39514e65ec4c10b0408e4aee8195bd5bc81e9df/log .

@fwyzard fwyzard merged commit 4a9d474 into cms-patatrack:CMSSW_10_2_X_Patatrack May 23, 2018
@fwyzard fwyzard deleted the tracking_code_cleanup branch May 23, 2018 14:24
fwyzard added a commit to fwyzard/cmssw that referenced this pull request Aug 14, 2018
@fwyzard
Clean up some non-GPU-related pixel tracking code
59e1716 
Backport clean up from the Patatrack fork (cms-patatrack#49)
fwyzard added a commit to fwyzard/cmssw that referenced this pull request Aug 14, 2018
@fwyzard
Clean up some non-GPU-related pixel tracking code
b1c8465 
Backport clean up from the Patatrack fork (cms-patatrack#49,
cms-patatrack#134)
fwyzard added a commit to fwyzard/cmssw that referenced this pull request Aug 14, 2018
@fwyzard
Clean up some non-GPU-related pixel tracking code
8a7cc72 
Cleanup whitespaces and indenttion, plugin definitions, includes, and
file names.

Backport from the Patatrack fork: cms-patatrack#49, cms-patatrack#122,
cms-patatrack#134.
fwyzard added a commit to fwyzard/cmssw that referenced this pull request Aug 14, 2018
@fwyzard
Clean up some non-GPU-related pixel tracking code
391debf 
Cleanup whitespaces and indenttion, plugin definitions, includes, and file names.

Backport from the Patatrack fork: cms-patatrack#49, cms-patatrack#122, cms-patatrack#134.
@fwyzard fwyzard mentioned this pull request Aug 14, 2018
Merged
fwyzard added a commit to fwyzard/cmssw that referenced this pull request Aug 14, 2018
@fwyzard
Clean up some non-GPU-related pixel tracking code
417c50c 
Cleanup whitespaces and indenttion, plugin definitions, includes, and file names.

Backport from the Patatrack fork: cms-patatrack#49, cms-patatrack#122, cms-patatrack#134.
@fwyzard fwyzard mentioned this pull request Aug 14, 2018
Merged
fwyzard added a commit to fwyzard/cmssw that referenced this pull request Aug 15, 2018
@fwyzard
Clean up some non-GPU-related pixel tracking code
5622c7a 
Cleanup whitespaces and indenttion, plugin definitions, includes, and file names.

Backport from the Patatrack fork: cms-patatrack#49, cms-patatrack#122, cms-patatrack#134.
fwyzard added a commit to fwyzard/cmssw that referenced this pull request Aug 15, 2018
@fwyzard
Clean up some non-GPU-related pixel tracking code
58a074d 
Cleanup whitespaces and indenttion, plugin definitions, includes, and file names.

Backport from the Patatrack fork: cms-patatrack#49, cms-patatrack#122, cms-patatrack#134.
fwyzard added a commit that referenced this pull request Oct 8, 2020
@fwyzard
Clean up some GPU- and non-GPU-related pixel tracking code (#49)
0a58fae 
  - clean up GPU- and non-GPU-related pixel tracking code and build files
  - drop obsolete or unused classes
  - rename RawToDigiGPU to SiPixelRawToDigiGPUKernel
  - move the definitions in SiPixelRawToDigiGPUKernel to the `pixelgpudetails` namespace
fwyzard added a commit that referenced this pull request Oct 8, 2020
@fwyzard
Clean up some non-GPU-related pixel tracking code
3b4acb0 
Cleanup whitespaces and indenttion, plugin definitions, includes, and file names.

Backport from the Patatrack fork: #49, #122, #134.
@fwyzard fwyzard mentioned this pull request Oct 8, 2020
Merged
fwyzard added a commit that referenced this pull request Oct 19, 2020
@fwyzard
Clean up some GPU- and non-GPU-related pixel tracking code (#49)
6fa1bc7 
  - clean up GPU- and non-GPU-related pixel tracking code and build files
  - drop obsolete or unused classes
  - rename RawToDigiGPU to SiPixelRawToDigiGPUKernel
  - move the definitions in SiPixelRawToDigiGPUKernel to the `pixelgpudetails` namespace
fwyzard added a commit that referenced this pull request Oct 19, 2020
@fwyzard
Clean up some non-GPU-related pixel tracking code
b6b3540 
Cleanup whitespaces and indenttion, plugin definitions, includes, and file names.

Backport from the Patatrack fork: #49, #122, #134.
fwyzard added a commit that referenced this pull request Oct 20, 2020
@fwyzard
Clean up some GPU- and non-GPU-related pixel tracking code (#49)
e41cec0 
  - clean up GPU- and non-GPU-related pixel tracking code and build files
  - drop obsolete or unused classes
  - rename RawToDigiGPU to SiPixelRawToDigiGPUKernel
  - move the definitions in SiPixelRawToDigiGPUKernel to the `pixelgpudetails` namespace
fwyzard added a commit that referenced this pull request Oct 20, 2020
@fwyzard
Clean up some non-GPU-related pixel tracking code
dfdda6d 
Cleanup whitespaces and indenttion, plugin definitions, includes, and file names.

Backport from the Patatrack fork: #49, #122, #134.
fwyzard added a commit that referenced this pull request Oct 23, 2020
@fwyzard
Clean up some GPU- and non-GPU-related pixel tracking code (#49)
c7f7705 
  - clean up GPU- and non-GPU-related pixel tracking code and build files
  - drop obsolete or unused classes
  - rename RawToDigiGPU to SiPixelRawToDigiGPUKernel
  - move the definitions in SiPixelRawToDigiGPUKernel to the `pixelgpudetails` namespace
fwyzard added a commit that referenced this pull request Oct 23, 2020
@fwyzard
Clean up some non-GPU-related pixel tracking code
b138c9e 
Cleanup whitespaces and indenttion, plugin definitions, includes, and file names.

Backport from the Patatrack fork: #49, #122, #134.
fwyzard added a commit that referenced this pull request Nov 6, 2020
@fwyzard
Clean up some GPU- and non-GPU-related pixel tracking code (#49)
724206d 
  - clean up GPU- and non-GPU-related pixel tracking code and build files
  - drop obsolete or unused classes
  - rename RawToDigiGPU to SiPixelRawToDigiGPUKernel
  - move the definitions in SiPixelRawToDigiGPUKernel to the `pixelgpudetails` namespace
fwyzard added a commit that referenced this pull request Nov 6, 2020
@fwyzard
Clean up some non-GPU-related pixel tracking code
c1c1a68 
Cleanup whitespaces and indenttion, plugin definitions, includes, and file names.

Backport from the Patatrack fork: #49, #122, #134.
fwyzard added a commit that referenced this pull request Nov 16, 2020
@fwyzard
Clean up some GPU- and non-GPU-related pixel tracking code (#49)
3820830 
  - clean up GPU- and non-GPU-related pixel tracking code and build files
  - drop obsolete or unused classes
  - rename RawToDigiGPU to SiPixelRawToDigiGPUKernel
  - move the definitions in SiPixelRawToDigiGPUKernel to the `pixelgpudetails` namespace
fwyzard added a commit that referenced this pull request Nov 16, 2020
@fwyzard
Clean up some non-GPU-related pixel tracking code
b6b0c11 
Cleanup whitespaces and indenttion, plugin definitions, includes, and file names.

Backport from the Patatrack fork: #49, #122, #134.
fwyzard pushed a commit that referenced this pull request Dec 25, 2020
@cmsbuild @fwyzard
Clean up some GPU- and non-GPU-related pixel tracking code (#49)
ed51c2b 
  - clean up GPU- and non-GPU-related pixel tracking code and build files
  - drop obsolete or unused classes
  - rename RawToDigiGPU to SiPixelRawToDigiGPUKernel
  - move the definitions in SiPixelRawToDigiGPUKernel to the `pixelgpudetails` namespace
fwyzard pushed a commit that referenced this pull request Dec 25, 2020
@cmsbuild @fwyzard
Clean up some non-GPU-related pixel tracking code
948f1e1 
Cleanup whitespaces and indenttion, plugin definitions, includes, and file names.

Backport from the Patatrack fork: #49, #122, #134.
fwyzard added a commit that referenced this pull request Dec 29, 2020
@fwyzard
Clean up some GPU- and non-GPU-related pixel tracking code (#49)
1da9842 
  - clean up GPU- and non-GPU-related pixel tracking code and build files
  - drop obsolete or unused classes
  - rename RawToDigiGPU to SiPixelRawToDigiGPUKernel
  - move the definitions in SiPixelRawToDigiGPUKernel to the `pixelgpudetails` namespace
fwyzard added a commit that referenced this pull request Dec 29, 2020
@fwyzard
Clean up some non-GPU-related pixel tracking code
0fc830c 
Cleanup whitespaces and indenttion, plugin definitions, includes, and file names.

Backport from the Patatrack fork: #49, #122, #134.
fwyzard added a commit that referenced this pull request Dec 29, 2020
@fwyzard
Clean up some non-GPU-related pixel tracking code
81b6d79 
Cleanup whitespaces and indenttion, plugin definitions, includes, and file names.

Backport from the Patatrack fork: #49, #122, #134.
fwyzard pushed a commit that referenced this pull request Feb 12, 2021
@Chriisbrown @skinnari
Track Quality Integration (#49)
f3c7d1d 
* Track Quality Integration

* Track Ntuple Maker Max Events

* PR Code Review Fixes #1

* Comments and style changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makortel makortel makortel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fwyzard @cmsbot @makortel