Implement ECAL rechits on GPU #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compilation warnings, remove commented out code, and apply code formatting rules.
fwyzard
reviewed
May 14, 2020
fwyzard
reviewed
May 14, 2020
| // Then only if the LS is different, update the laser correction | ||
| // The variation within a LS is not worth pursuing (<< 0.1% !!) | ||
| // and below the precision we can claim on the laser corrections (right?). | ||
| // This will save quite some time (also for the CPU version?) |
There was a problem hiding this comment.
do the corrections actually change within a lumisection ?
or rather, does the interpolation has a granularity smaller than the lumisection ?
There was a problem hiding this comment.
Current correction is based on "time". Namely, we have two measurements, one every 40 minutes, and we perform a linear interpolation among them.
Based on the code I would say that the correction is really time dependent, time of the event.
float interpolatedLaserResponse = p_i / apdpnref + float(tt - t_i) * (p_f - p_i) / (apdpnref * float(t_f - t_i));
One possibility (just an idea) to speed up is to calculate the correction once every LS. From physics point of view, this should have ~ no effect (24 seconds step function vs linear interpolation that extend 40 minutes), but it can be tested with the current available data.
Computationally wise, this could save some time.
To be discussed with who wrote in first place the interpolation code to see if there is something subtle I am missing (special cases).
There was a problem hiding this comment.
Sounds like a very good idea !
(I always assumed the corrections were LS-based and handled by the EventSetup... this shows how far one can be wrong with reasonable assumptions)
fwyzard
reviewed
May 14, 2020
fwyzard
reviewed
May 14, 2020
fwyzard
reviewed
May 14, 2020
fwyzard
reviewed
May 14, 2020
fwyzard
reviewed
May 14, 2020
fwyzard
reviewed
May 14, 2020
fwyzard
reviewed
May 14, 2020
fwyzard
reviewed
May 14, 2020
|
Validation plots attached. In the following energy and chi2 for the rechits reconstructed in both cpu and gpu. NB: there are some cases where gpu is not reconstructed, coming from recovered channels. I am investigating the few outliers.
|
fwyzard
changed the title
fwyzard
reviewed
May 31, 2020
RecoLocalCalo/EcalRecAlgos/bin/makeEcalMultifitResultsGpuValidationPlots.cpp
Outdated
Show resolved
Hide resolved
fwyzard
reviewed
May 31, 2020
RecoLocalCalo/EcalRecAlgos/bin/makeEcalMultifitResultsGpuValidationPlots.cpp
Outdated
Show resolved
Hide resolved
fwyzard
approved these changes
May 31, 2020
makortel
reviewed
Jun 1, 2020
RecoLocalCalo/EcalRecProducers/plugins/EcalCPURecHitProducer.cc
Outdated
Show resolved
Hide resolved
RecoLocalCalo/EcalRecProducers/plugins/EcalCPURecHitProducer.cc
Outdated
Show resolved
Hide resolved
RecoLocalCalo/EcalRecProducers/plugins/EcalRecHitConvertGPU2CPUFormat.cc
Outdated
Show resolved
Hide resolved
RecoLocalCalo/EcalRecProducers/plugins/EcalRecHitConvertGPU2CPUFormat.cc
Outdated
Show resolved
Hide resolved
makortel
reviewed
Jun 1, 2020
RecoLocalCalo/EcalRecProducers/plugins/EcalRecHitProducerGPU.cc
Outdated
Show resolved
Hide resolved
RecoLocalCalo/EcalRecProducers/plugins/EcalRecHitProducerGPU.cc
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Validation summaryReference release CMSSW_11_1_0_pre8 at 442ae07 Validation plots/RelValTTbar_14TeV/CMSSW_11_0_0_patch1-PU_110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
Throughput plots/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53
logs and
|
fwyzard
pushed a commit
that referenced
this pull request
Oct 7, 2020
Include standalone executables for the validation of ECAL uncalibrated and calibrated rechits.
fwyzard
pushed a commit
that referenced
this pull request
Oct 8, 2020
Include standalone executables for the validation of ECAL uncalibrated and calibrated rechits.
fwyzard
pushed a commit
that referenced
this pull request
Oct 8, 2020
Include standalone executables for the validation of ECAL uncalibrated and calibrated rechits.
fwyzard
pushed a commit
that referenced
this pull request
Nov 9, 2020
Include standalone executables for the validation of ECAL uncalibrated and calibrated rechits.
fwyzard
pushed a commit
that referenced
this pull request
Nov 12, 2020
Include standalone executables for the validation of ECAL uncalibrated and calibrated rechits.
fwyzard
pushed a commit
that referenced
this pull request
Nov 16, 2020
Include standalone executables for the validation of ECAL uncalibrated and calibrated rechits.
fwyzard
pushed a commit
that referenced
this pull request
Dec 25, 2020
Include standalone executables for the validation of ECAL uncalibrated and calibrated rechits.
fwyzard
pushed a commit
that referenced
this pull request
Dec 29, 2020
Include standalone executables for the validation of ECAL uncalibrated and calibrated rechits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From uncalibrated rechit to rechit on GPU, in CMSSW_11_1_X
The PR includes validation code for rechit comparison, similar to what shown at ECAL DPG meeting.
Some to the files changed are just "c++ stylistic", it can be reversed (I needed to debug).
Similar to #457 but mergeable.