Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for the framework PR #426

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CUDADataFormats/Common/test/test_CUDAProduct.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ TEST_CASE("Use of CUDAProduct template", "[CUDACore]") {
auto bar = std::move(foo);
}

requireCUDADevices();
if (not hasCUDADevices()) {
return;
}

constexpr int defaultDevice = 0;
cudaCheck(cudaSetDevice(defaultDevice));
Expand Down
4 changes: 3 additions & 1 deletion HeterogeneousCore/CUDACore/test/test_CUDAScopedContext.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ namespace {
} // namespace

TEST_CASE("Use of CUDAScopedContext", "[CUDACore]") {
requireCUDADevices();
if (not hasCUDADevices()) {
return;
}

constexpr int defaultDevice = 0;
{
Expand Down
15 changes: 0 additions & 15 deletions HeterogeneousCore/CUDATest/python/prod1_cff.py

This file was deleted.

15 changes: 0 additions & 15 deletions HeterogeneousCore/CUDATest/python/prod5_cff.py

This file was deleted.

2 changes: 1 addition & 1 deletion HeterogeneousCore/CUDATest/python/prod6CPU_cfi.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import FWCore.ParameterSet.Config as cms

from HeterogeneousCore.CUDATest.testCUDAProducerCPU_cfi import testCUDAProducerCPU as _testCUDAProducerCPU
prod6CPU = _testCUDAProducerCPU.clone(src = "prod5CPU")
prod6CPU = _testCUDAProducerCPU.clone(src = "prod5")
16 changes: 0 additions & 16 deletions HeterogeneousCore/CUDATest/python/prod6_cff.py

This file was deleted.

1 change: 0 additions & 1 deletion HeterogeneousCore/CUDATest/test/testCUDASwitch_cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#includeAnalyzer = True
includeAnalyzer = False

from Configuration.ProcessModifiers.gpu_cff import gpu
process = cms.Process("Test")
process.load("FWCore.MessageService.MessageLogger_cfi")
process.load("HeterogeneousCore.CUDAServices.CUDAService_cfi")
Expand Down
79 changes: 0 additions & 79 deletions HeterogeneousCore/CUDATest/test/testCUDA_cfg.py

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ process.moduleToTest(process.toTest)
SECTION("base configuration is OK") { REQUIRE_NOTHROW(edm::test::TestProcessor(config)); }

SECTION("No event data") {
// Calls produce(), so don't call without a GPU
if (not hasCUDADevices()) {
return;
}
edm::test::TestProcessor tester(config);

REQUIRE_NOTHROW(tester.test());
Expand Down Expand Up @@ -59,7 +63,9 @@ process.moduleToTest(process.toTest)
)_"};
edm::test::TestProcessor::Config config{baseConfig};

requireCUDADevices();
if (not hasCUDADevices()) {
return;
}

constexpr int defaultDevice = 0;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#ifndef HeterogeneousCore_CUDAUtilities_requireCUDADevices_h
#define HeterogeneousCore_CUDAUtilities_requireCUDADevices_h

bool hasCUDADevices();

void requireCUDADevices();

#endif // HeterogeneousCore_CUDAUtilities_requireCUDADevices_h
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,24 @@

#include "HeterogeneousCore/CUDAUtilities/interface/requireCUDADevices.h"

void requireCUDADevices() {
bool hasCUDADevices() {
int devices = 0;
auto status = cudaGetDeviceCount(&devices);
if (status != cudaSuccess) {
std::cerr << "Failed to initialise the CUDA runtime, the test will be skipped."
<< "\n";
exit(EXIT_SUCCESS);
return false;
}
if (devices == 0) {
std::cerr << "No CUDA devices available, the test will be skipped."
<< "\n";
return false;
}
return true;
}

void requireCUDADevices() {
if (not hasCUDADevices()) {
exit(EXIT_SUCCESS);
}
}
4 changes: 3 additions & 1 deletion HeterogeneousCore/CUDAUtilities/test/copyAsync_t.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
#include "HeterogeneousCore/CUDAUtilities/interface/requireCUDADevices.h"

TEST_CASE("copyAsync", "[cudaMemTools]") {
requireCUDADevices();
if (not hasCUDADevices()) {
return;
}

cudaStream_t stream;
cudaCheck(cudaStreamCreateWithFlags(&stream, cudaStreamNonBlocking));
Expand Down
4 changes: 3 additions & 1 deletion HeterogeneousCore/CUDAUtilities/test/device_unique_ptr_t.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
#include "HeterogeneousCore/CUDAUtilities/interface/requireCUDADevices.h"

TEST_CASE("device_unique_ptr", "[cudaMemTools]") {
requireCUDADevices();
if (not hasCUDADevices()) {
return;
}

cudaStream_t stream;
cudaCheck(cudaStreamCreateWithFlags(&stream, cudaStreamNonBlocking));
Expand Down
4 changes: 3 additions & 1 deletion HeterogeneousCore/CUDAUtilities/test/host_unique_ptr_t.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
#include "HeterogeneousCore/CUDAUtilities/interface/requireCUDADevices.h"

TEST_CASE("host_unique_ptr", "[cudaMemTools]") {
requireCUDADevices();
if (not hasCUDADevices()) {
return;
}

cudaStream_t stream;
cudaCheck(cudaStreamCreateWithFlags(&stream, cudaStreamNonBlocking));
Expand Down
4 changes: 3 additions & 1 deletion HeterogeneousCore/CUDAUtilities/test/memsetAsync_t.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
#include "HeterogeneousCore/CUDAUtilities/interface/requireCUDADevices.h"

TEST_CASE("memsetAsync", "[cudaMemTools]") {
requireCUDADevices();
if (not hasCUDADevices()) {
return;
}

cudaStream_t stream;
cudaCheck(cudaStreamCreateWithFlags(&stream, cudaStreamNonBlocking));
Expand Down