Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move warning in producer #422

Merged
merged 1 commit into from
Dec 2, 2019
Merged

move warning in producer #422

merged 1 commit into from
Dec 2, 2019

Conversation

VinInn
Copy link

@VinInn VinInn commented Dec 2, 2019 •
edited
Loading

title says it all

@VinInn VinInn mentioned this pull request Dec 2, 2019
Closed
fwyzard added a commit that referenced this pull request Dec 2, 2019
@fwyzard
Move LogWarning into the EDProducer (#422)
952ade3 
In CMSSW 11.0.0 the MessageLogger is no longer usable in CUDA code due
to the use of c++17 featutres.
@fwyzard
Copy link

fwyzard commented Dec 2, 2019

Indeed this is a much simpler and less intrusive change :)

@fwyzard fwyzard changed the base branch from CMSSW_11_0_X_Patatrack to master December 2, 2019 13:32
@fwyzard
Copy link

fwyzard commented Dec 2, 2019

Moved to master to be used for building the next Patatrack release.

@fwyzard
Copy link

fwyzard commented Dec 2, 2019

Provisionally merging in master while @AdrianoDee runs the usual validation (no changes expected).

@fwyzard fwyzard merged commit 14ccdc6 into cms-patatrack:master Dec 2, 2019
fwyzard pushed a commit that referenced this pull request Dec 2, 2019
@VinInn @fwyzard
Move LogWarning into the EDProducer (#422)
9d78eff 
In CMSSW 11.0.0 the MessageLogger is no longer usable in CUDA code due
to the use of c++17 featutres.
@AdrianoDee
Copy link

Validation summary

Reference release CMSSW_11_0_0_pre12 at e626860
Development branch CMSSW_11_0_X_Patatrack at cb27c23
Testing PRs:

Validation plots

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 10824.5
  • tracking validation plots and summary for workflow 10824.51
  • tracking validation plots and summary for workflow 10824.52

/RelValZMM_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 10824.5
  • tracking validation plots and summary for workflow 10824.51
  • tracking validation plots and summary for workflow 10824.52

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_design_v3-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 10824.5
  • tracking validation plots and summary for workflow 10824.51
  • tracking validation plots and summary for workflow 10824.52

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

scan-136.86452.png
zoom-136.86452.png

logs and nvprof/nvvp profiles

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 10824.5
  • development release, workflow 10824.5
  • development release, workflow 10824.51
  • development release, workflow 10824.52
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 136.86452
  • testing release, workflow 10824.5
  • testing release, workflow 10824.51
  • testing release, workflow 10824.52
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 136.86452

/RelValZMM_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 10824.5
  • development release, workflow 10824.5
  • development release, workflow 10824.51
  • development release, workflow 10824.52
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 136.86452
  • testing release, workflow 10824.5
  • testing release, workflow 10824.51
  • testing release, workflow 10824.52
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 136.86452

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_design_v3-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 10824.5
  • development release, workflow 10824.5
  • development release, workflow 10824.51
  • development release, workflow 10824.52
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 136.86452
  • testing release, workflow 10824.5
  • testing release, workflow 10824.51
  • testing release, workflow 10824.52
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 136.86452

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/ac1089547b0361938b5c4ca59555d2dcedface89/log .

fwyzard pushed a commit that referenced this pull request Oct 8, 2020
@VinInn @fwyzard
Move LogWarning into the EDProducer (#422)
8a92645 
In CMSSW 11.0.0 the MessageLogger is no longer usable in CUDA code due
to the use of c++17 featutres.
@fwyzard fwyzard mentioned this pull request Oct 8, 2020
Merged
fwyzard pushed a commit that referenced this pull request Oct 19, 2020
@VinInn @fwyzard
Move LogWarning into the EDProducer (#422)
abf71f6 
In CMSSW 11.0.0 the MessageLogger is no longer usable in CUDA code due
to the use of c++17 featutres.
fwyzard pushed a commit that referenced this pull request Oct 20, 2020
@VinInn @fwyzard
Move LogWarning into the EDProducer (#422)
f18143e 
In CMSSW 11.0.0 the MessageLogger is no longer usable in CUDA code due
to the use of c++17 featutres.
fwyzard pushed a commit that referenced this pull request Oct 23, 2020
@VinInn @fwyzard
Move LogWarning into the EDProducer (#422)
30f147f 
In CMSSW 11.0.0 the MessageLogger is no longer usable in CUDA code due
to the use of c++17 featutres.
fwyzard pushed a commit that referenced this pull request Nov 6, 2020
@VinInn @fwyzard
Move LogWarning into the EDProducer (#422)
a46353c 
In CMSSW 11.0.0 the MessageLogger is no longer usable in CUDA code due
to the use of c++17 featutres.
fwyzard pushed a commit that referenced this pull request Nov 16, 2020
@VinInn @fwyzard
Move LogWarning into the EDProducer (#422)
f6aada4 
In CMSSW 11.0.0 the MessageLogger is no longer usable in CUDA code due
to the use of c++17 featutres.
fwyzard added a commit that referenced this pull request Nov 27, 2020
@fwyzard
Move LogWarning into the EDProducer (#422)
6d2669f 
In CMSSW 11.0.0 the MessageLogger is no longer usable in CUDA code due
to the use of c++17 featutres.
fwyzard pushed a commit that referenced this pull request Dec 25, 2020
@cmsbuild @fwyzard
Move LogWarning into the EDProducer (#422)
78b056e 
In CMSSW 11.0.0 the MessageLogger is no longer usable in CUDA code due
to the use of c++17 featutres.
fwyzard pushed a commit that referenced this pull request Dec 29, 2020
@VinInn @fwyzard
Move LogWarning into the EDProducer (#422)
9d2ab95 
In CMSSW 11.0.0 the MessageLogger is no longer usable in CUDA code due
to the use of c++17 featutres.
fwyzard pushed a commit that referenced this pull request Dec 29, 2020
@VinInn @fwyzard
Move LogWarning into the EDProducer (#422)
2595d76 
In CMSSW 11.0.0 the MessageLogger is no longer usable in CUDA code due
to the use of c++17 featutres.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VinInn @fwyzard @AdrianoDee