Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement triplets in the pixel ntuplet producer #382

Merged
merged 34 commits into from
Sep 9, 2019
Merged

Implement triplets in the pixel ntuplet producer #382

merged 34 commits into from
Sep 9, 2019

Conversation

fwyzard
Copy link

@fwyzard fwyzard commented Sep 9, 2019

To enable pixel triplets:

process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

The code should be cleaned up to avoid "magic numbers".

This PR is a rebase of the (updated) #362 on top of the current master.
See also the discussion and comments in #362 and #377.

VinInn added 30 commits August 15, 2019 10:04
@VinInn @fwyzard
compute average pixel geometry
1d35cbc
@VinInn @fwyzard
correct average geometry for the beamspot
2309b4e 
Conflicts:
	RecoLocalTracker/SiPixelRecHits/plugins/gpuPixelRecHits.h
@VinInn @fwyzard
use correct geometry fro holes
13f5b1b
@VinInn @fwyzard
add outer triplets
5b965e1
@VinInn @fwyzard
tune gap
6df8cd8
@VinInn @fwyzard
protect for no hits
8ef2ac1
@VinInn @fwyzard
improve debug output
523be65
@VinInn @fwyzard
implement sort of iteration
423a02a
@VinInn @fwyzard
enable barrel jumping doublets
ceeb20e
@VinInn @fwyzard
add forward layers
ec935d6
@VinInn @fwyzard
make it fully configurable
1a636f1
@VinInn @fwyzard
small optimization to gain speed
103ab8c
@VinInn @fwyzard
keep the alternative for doc
a11380c
@VinInn @fwyzard
inline by hand, can be backported
fcee0ec
@VinInn @fwyzard
increase sizes to avoid overflow in case of triplets reco with noise
3779730
@VinInn @fwyzard
more tuning
6f0c14e
@VinInn @fwyzard
renumber layer pairs
442caf9
@VinInn @fwyzard
small cleanup
ec68fed
@VinInn @fwyzard
debug output
13582b2
@VinInn @fwyzard
protect debug
4d9eb69
@VinInn @fwyzard
move early fishbone after connect
83f7acc
@VinInn @fwyzard
add comments
9ce85f2
@VinInn @fwyzard
increase number of concurrent fits to max
624a0cb
@VinInn @fwyzard
rename configurable, tell clang not to formats constants
4bc77aa
@VinInn @fwyzard
initialize quality asap, fill multiplicty only if not duplicate
0727def
@VinInn @fwyzard
avoid to fit duplicates
6bba031
@VinInn @fwyzard
avoid checking twice multiplcity
65af09a
@VinInn @fwyzard
count fitted tracks
c0c3c9a
@VinInn @fwyzard
add more jumping forward doublets, retune cuts
80d410e
@VinInn @fwyzard
fix format, make space for forward doublets
61b38f0
@fwyzard fwyzard merged commit 777198b into CMSSW_10_6_X_Patatrack Sep 9, 2019
@fwyzard fwyzard mentioned this pull request Sep 9, 2019
Closed
@fwyzard fwyzard deleted the rebase/362 branch December 2, 2019 16:05
fwyzard pushed a commit that referenced this pull request Oct 8, 2020
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
36875c7 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Oct 8, 2020
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
ee6ba89 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
This was referenced Oct 8, 2020
Merged
Merged
fwyzard pushed a commit that referenced this pull request Oct 19, 2020
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
7f53d53 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Oct 20, 2020
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
fb55542 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Oct 20, 2020
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
d065da0 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Oct 20, 2020
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
f49f9db 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Oct 23, 2020
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
2a8ea85 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Oct 23, 2020
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
da4282e 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Nov 6, 2020
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
cd94b8e 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Nov 6, 2020
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
a47cc3d 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Nov 6, 2020
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
7841498 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Nov 16, 2020
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
804e5aa 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Nov 16, 2020
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
1d3a652 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard added a commit that referenced this pull request Nov 27, 2020
@fwyzard
Implement triplets in the pixel ntuplet producer (#382)
05c409a 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard added a commit that referenced this pull request Nov 27, 2020
@fwyzard
Implement triplets in the pixel ntuplet producer (#382)
d319278 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Dec 25, 2020
@cmsbuild @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
d5d1f2c 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Dec 26, 2020
@cmsbuild @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
01a7e30 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
@fwyzard fwyzard mentioned this pull request Dec 26, 2020
Merged
fwyzard pushed a commit that referenced this pull request Dec 29, 2020
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
47a8a8f 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Dec 29, 2020
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
f177e9e 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Jan 15, 2021
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
070ff4a 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Mar 23, 2021
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
1203734 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
fwyzard pushed a commit that referenced this pull request Apr 1, 2021
@VinInn @fwyzard
Implement triplets in the pixel ntuplet producer (#382)
9e6ca10 
Enable pixel triplets with:

    process.pixelTracksHitQuadruplets.minHitsPerNtuplet = 3
    process.pixelTracksHitQuadruplets.includeJumpingForwardDoublets = True

Changes:
  - adjust for the average pixel geometry and the beam spot position;
  - allow "jumping doublets" in the forward region (FPIX1-FPIX3) for triplets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fwyzard @VinInn