Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ClusterTPAssociationHeterogeneous to the new framework #346

Merged
merged 2 commits into from
May 15, 2019
Merged

Migrate ClusterTPAssociationHeterogeneous to the new framework #346

merged 2 commits into from
May 15, 2019

Conversation

fwyzard
Copy link

@fwyzard fwyzard commented May 13, 2019

No description provided.

@fwyzard
Copy link
Author

fwyzard commented May 13, 2019 •
edited
Loading

Split #324, part 8 of 8.

fwyzard pushed a commit that referenced this pull request May 13, 2019
@VinInn @fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
c3fbfa5
@fwyzard fwyzard force-pushed the Migrate_ClusterTPAssociationHeterogeneous branch from 94061f4 to afa98f4 Compare May 13, 2019 14:11
@fwyzard fwyzard changed the title Migrate ClusterTPAssociationHeterogeneous to the new heterogeneous framework Migrate ClusterTPAssociationHeterogeneous to the new framework May 13, 2019
fwyzard pushed a commit that referenced this pull request May 13, 2019
@VinInn @fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
c9dd1f9
fwyzard pushed a commit that referenced this pull request May 13, 2019
@VinInn @fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
8469d49
fwyzard pushed a commit that referenced this pull request May 13, 2019
@VinInn @fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
6939315
makortel
makortel reviewed May 13, 2019
View reviewed changes
SimTracker/TrackerHitAssociation/plugins/ClusterTPAssociationHeterogeneous.cc
heterogeneous::GPUCuda, heterogeneous::CPU>>
{
class ClusterTPAssociationHeterogeneous
: public HeterogeneousEDProducer<heterogeneous::HeterogeneousDevices<heterogeneous::GPUCuda, heterogeneous::CPU>> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClusterTPAssociationHeterogeneous seems to stay HeterogeneousEDProducer, so the title of this PR is misleading.

By cursory look this PR introduces the TrackingRecHit2DCUDA, and migrates the CklusterTPAssociationHeterogeneous do use that. The hit-producing code SiPixelRecHitHeterogeneous appears to still produce HeterogeneousProduct, so there is nothing that would produce TrackingRecHit2DCUDA.

Should this PR also include the migration of SiPixelRecHitHeterogeneous to the new framework?

@fwyzard
Copy link
Author

fwyzard commented May 13, 2019

@makortel this PR is actually supposed to be one of the last steps if #338 ; does it look better in that context ?

@makortel
Copy link

this PR is actually supposed to be one of the last steps if #338 ; does it look better in that context ?

Sort of yes, but I just assumed that this PR would have been self-contained as it was split from #324/#338 (as all the other similar PRs were, right?).

fwyzard pushed a commit that referenced this pull request May 13, 2019
@VinInn @fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
4e22f07
fwyzard pushed a commit that referenced this pull request May 13, 2019
@VinInn @fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
c279409
fwyzard pushed a commit that referenced this pull request May 13, 2019
@VinInn @fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
ce8a88c
fwyzard pushed a commit that referenced this pull request May 14, 2019
@VinInn @fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
9e94f5c
fwyzard pushed a commit that referenced this pull request May 14, 2019
@VinInn @fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
a61b93e
fwyzard pushed a commit that referenced this pull request May 14, 2019
@VinInn @fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
b63b35f
fwyzard pushed a commit that referenced this pull request May 14, 2019
@VinInn @fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
cfd0a39
@fwyzard fwyzard added the Pixels Pixels-related developments label May 15, 2019
@fwyzard fwyzard merged commit 3c590fa into CMSSW_10_6_X_Patatrack May 15, 2019
@fwyzard fwyzard deleted the Migrate_ClusterTPAssociationHeterogeneous branch May 15, 2019 09:44
fwyzard added a commit that referenced this pull request Oct 8, 2020
@fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
f3c953f
fwyzard added a commit that referenced this pull request Oct 8, 2020
@fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
dc8a414
This was referenced Oct 8, 2020
Merged
Merged
fwyzard added a commit that referenced this pull request Oct 19, 2020
@fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
58612a8
fwyzard added a commit that referenced this pull request Oct 20, 2020
@fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
0207fa1
fwyzard added a commit that referenced this pull request Oct 23, 2020
@fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
8bfba2f
fwyzard added a commit that referenced this pull request Nov 6, 2020
@fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
2d85b68
fwyzard added a commit that referenced this pull request Nov 16, 2020
@fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
84b50b9
fwyzard added a commit that referenced this pull request Nov 27, 2020
@fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
fc00547
fwyzard added a commit that referenced this pull request Nov 28, 2020
@fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
2b5e397
fwyzard pushed a commit that referenced this pull request Dec 25, 2020
@cmsbuild @fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
0ac3dc8
fwyzard added a commit that referenced this pull request Dec 26, 2020
@fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
7a83b11
fwyzard added a commit that referenced this pull request Dec 29, 2020
@fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
39acea9
fwyzard added a commit that referenced this pull request Dec 29, 2020
@fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
c5031d4
fwyzard added a commit that referenced this pull request Dec 29, 2020
@fwyzard
Migrate ClusterTPAssociationHeterogeneous to the new framework (#346)
65c4ff2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makortel makortel makortel left review comments

Assignees
No one assigned
Labels
Pixels Pixels-related developments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fwyzard @makortel @VinInn