Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid narrowing conversion from "unsigned int" to "unsigned char" #250

Merged

Conversation

fwyzard
Copy link

@fwyzard fwyzard commented Jan 17, 2019

Fix warnings along the lines of

RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu(435): warning: invalid narrowing conversion from "unsigned int" to "unsigned char"
RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu(479): warning: invalid narrowing conversion from "unsigned int" to "unsigned char"
RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu(494): warning: invalid narrowing conversion from "unsigned int" to "unsigned char"

@fwyzard
Copy link
Author

fwyzard commented Jan 17, 2019

Validation summary

Reference release CMSSW_10_4_0 at b8365c6
Development branch CMSSW_10_4_X_Patatrack at 6218478
Testing PRs:

makeTrackValidationPlots.py plots

/RelValTTbar_13/CMSSW_10_4_0_pre3-PU25ns_103X_upgrade2018_realistic_v8-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_4_0_pre3-103X_upgrade2018_realistic_v8-v1/GEN-SIM-DIGI-RAW

logs and nvprof/nvvp profiles

/RelValTTbar_13/CMSSW_10_4_0_pre3-PU25ns_103X_upgrade2018_realistic_v8-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_4_0_pre3-103X_upgrade2018_realistic_v8-v1/GEN-SIM-DIGI-RAW

Logs

The full log is available at https://fwyzard.web.cern.ch/fwyzard/patatrack/pulls/5f88247d68e99f38cd121b967ed413e7c9b29fb9/log .

@fwyzard
Copy link
Author

fwyzard commented Jan 17, 2019

No changes in performance: 1869.7 ± 3.0 ev/s (before) vs 1869.7 ± 6.6 ev/s (after).

@fwyzard fwyzard merged commit 4645001 into cms-patatrack:CMSSW_10_4_X_Patatrack Jan 17, 2019
@fwyzard fwyzard deleted the patatrack_fix_warnings branch January 17, 2019 11:12
@fwyzard
Copy link
Author

fwyzard commented Jan 17, 2019

No changes in physics, as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant