Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress asserts in the GPU code, unless GPU_DEBUG is defined #186

Merged
merged 2 commits into from
Oct 6, 2018
Merged

Suppress asserts in the GPU code, unless GPU_DEBUG is defined #186

merged 2 commits into from
Oct 6, 2018

Conversation

fwyzard
Copy link

@fwyzard fwyzard commented Oct 6, 2018

No description provided.

@fwyzard
Copy link
Author

fwyzard commented Oct 6, 2018 •
edited
Loading

Validation summary

Reference release CMSSW_10_2_5 at a8a031d
Development branch CMSSW_10_2_X_Patatrack at 4d789eb
Testing PRs:

makeTrackValidationPlots.py plots

/RelValTTbar_13/CMSSW_10_2_2-PU25ns_102X_upgrade2018_realistic_v11-v2/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_2-102X_upgrade2018_realistic_v11-v1/GEN-SIM-DIGI-RAW

DQM GUI plots

/RelValTTbar_13/CMSSW_10_2_2-PU25ns_102X_upgrade2018_realistic_v11-v2/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_2-102X_upgrade2018_realistic_v11-v1/GEN-SIM-DIGI-RAW

logs and nvprof/nvvp profiles

/RelValTTbar_13/CMSSW_10_2_2-PU25ns_102X_upgrade2018_realistic_v11-v2/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_2-102X_upgrade2018_realistic_v11-v1/GEN-SIM-DIGI-RAW

Logs

The full log is available at https://fwyzard.web.cern.ch/fwyzard/patatrack/pulls/51cb18c08648b23a767f3d5f9b6f492c72d351e9/log .

@fwyzard fwyzard mentioned this pull request Oct 6, 2018
Closed
makortel
makortel reviewed Oct 6, 2018
View reviewed changes
CondFormats/SiPixelObjects/interface/SiPixelGainForHLTonGPU.h Outdated
#define NDEBUG
#endif // NDEBUG
#endif // GPU_DEBUG
#endif // __CUDA_ARCH__
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow it would feel nice to abstract this piece to a common place, but I'm not sure if, in the end, it would ask more trouble than it would help.

@fwyzard
Copy link
Author

fwyzard commented Oct 6, 2018 via email

@fwyzard
Copy link
Author

fwyzard commented Oct 6, 2018

OK, both on Linux and on OS X assert.hundefines assert and redefines it depending on the value of NDEBUG.
So it should work to move the check, the possible definition of NDEBUG, and the inclusion of assert.h/cassert to a separate file.

@fwyzard
Copy link
Author

fwyzard commented Oct 6, 2018 •
edited
Loading

Validation summary

Reference release CMSSW_10_2_5 at a8a031d
Development branch CMSSW_10_2_X_Patatrack at af3ccf5
Testing PRs:

makeTrackValidationPlots.py plots

/RelValTTbar_13/CMSSW_10_2_2-PU25ns_102X_upgrade2018_realistic_v11-v2/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_2-102X_upgrade2018_realistic_v11-v1/GEN-SIM-DIGI-RAW

DQM GUI plots

/RelValTTbar_13/CMSSW_10_2_2-PU25ns_102X_upgrade2018_realistic_v11-v2/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_2-102X_upgrade2018_realistic_v11-v1/GEN-SIM-DIGI-RAW

logs and nvprof/nvvp profiles

/RelValTTbar_13/CMSSW_10_2_2-PU25ns_102X_upgrade2018_realistic_v11-v2/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_2-102X_upgrade2018_realistic_v11-v1/GEN-SIM-DIGI-RAW

Logs

The full log is available at https://fwyzard.web.cern.ch/fwyzard/patatrack/pulls/0e8417bd484d07eab83359a4828225a575efdff3/log .

@fwyzard fwyzard merged commit 0e3f658 into cms-patatrack:CMSSW_10_2_X_Patatrack Oct 6, 2018
@fwyzard fwyzard deleted the assert_with_GPU_DEBUG branch October 6, 2018 13:04
@fwyzard fwyzard added this to the CMSSW_10_2_6_Patatrack milestone Oct 31, 2018
@makortel makortel mentioned this pull request Jul 2, 2019
Closed
fwyzard added a commit that referenced this pull request Oct 8, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
1cf5759
fwyzard added a commit that referenced this pull request Oct 8, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
5d871c9
This was referenced Oct 8, 2020
Merged
Merged
fwyzard added a commit that referenced this pull request Oct 19, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
14b5548
fwyzard added a commit that referenced this pull request Oct 20, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
851688b
fwyzard added a commit that referenced this pull request Oct 20, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
7f89fb7
fwyzard added a commit that referenced this pull request Oct 20, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
774dd8a
fwyzard added a commit that referenced this pull request Oct 23, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
f5713e0
fwyzard added a commit that referenced this pull request Oct 23, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
534e108
fwyzard added a commit that referenced this pull request Nov 6, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
6efe78c
fwyzard added a commit that referenced this pull request Nov 6, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
73cf915
fwyzard added a commit that referenced this pull request Nov 6, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
0663adc
fwyzard added a commit that referenced this pull request Nov 16, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
3ec0b3d
fwyzard added a commit that referenced this pull request Nov 16, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
6992c36
fwyzard added a commit that referenced this pull request Nov 27, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
e3271d4
fwyzard added a commit that referenced this pull request Nov 28, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
6d4266d
fwyzard pushed a commit that referenced this pull request Dec 25, 2020
@cmsbuild @fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
3e9ae4c
fwyzard pushed a commit that referenced this pull request Dec 26, 2020
@cmsbuild @fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
549b6b5
@fwyzard fwyzard mentioned this pull request Dec 26, 2020
Merged
fwyzard added a commit that referenced this pull request Dec 26, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
3aac794
fwyzard added a commit that referenced this pull request Dec 29, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
e0b52c8
fwyzard added a commit that referenced this pull request Dec 29, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
6ed56a5
fwyzard added a commit that referenced this pull request Dec 29, 2020
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
794318e
fwyzard added a commit that referenced this pull request Jan 15, 2021
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
e138323
fwyzard added a commit that referenced this pull request Mar 23, 2021
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
041530e
fwyzard added a commit that referenced this pull request Apr 1, 2021
@fwyzard
Suppress asserts in the GPU code, unless GPU_DEBUG is defined (#186)
e1c1a7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makortel makortel makortel left review comments

Assignees
No one assigned
Labels
bug fixed
Projects
None yet
Milestone
CMSSW_10_2_6_Patatrack
Development

Successfully merging this pull request may close these issues.
2 participants
@fwyzard @makortel