Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) #171

Merged
merged 37 commits into from
Sep 26, 2018
Merged

Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) #171

merged 37 commits into from
Sep 26, 2018

Conversation

VinInn
Copy link

@VinInn VinInn commented Sep 22, 2018 •
edited
Loading

  1. introduce ClusterChargeCut: remove noise in real data and make GPU much closer to CPU
  2. optimize Histogramming: use two step filling.
    faster, use less memory, avoid spilling: clusterizers are now 40% faster
  3. Vertices are now sorted on GPU
    Physics performances unchanged

VinInn added 26 commits September 14, 2018 16:08
@VinInn
use ext ws or shared
eb29a8b
@VinInn
add minBLperML and a debug printout
fe2af2e
@VinInn
a small prefix scan in single block
8b47a72
@VinInn
add charge cut
90344c7
@VinInn
apply charge cut
b1e7746
@VinInn
ccc works
dca2f1e
@VinInn
stable, but something fishy in test
6a06ece
@VinInn
of course de test had a bug
50460d9
@VinInn
works, sort only with blksize 256
9103a9c
@VinInn
make the number of bins configurable
f05df88
@VinInn
fix race
304c607
@VinInn
compactify the histogram (to make itaration faster?)
b1e2810
@VinInn
not faster, at least avoid spill
f9dad13
@VinInn
will need some cleanup
81a15e6
@VinInn
clean hist header
8eb1210
@VinInn
use one bin per column
960de3d
@VinInn
from done to more, and debug
25b24c5
@VinInn
vertex finding is faster now
7097934
@VinInn
use new clustering for real!
a108571
@VinInn
test cub as well
c711b5d
@VinInn
works in c++
83879cd
@VinInn
works
ba38606
@VinInn
old histo is gone
b8df4f8
@VinInn
wip
1bb3bda
@VinInn
wip
78e4aa5
@VinInn
does not crash
0c19cd1
fwyzard pushed a commit that referenced this pull request Oct 20, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
35fa9b8
fwyzard pushed a commit that referenced this pull request Oct 20, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
c6a47eb
fwyzard pushed a commit that referenced this pull request Oct 20, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
7214dff
fwyzard pushed a commit that referenced this pull request Oct 20, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
820b0f7
fwyzard pushed a commit that referenced this pull request Oct 23, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
12c35e8
fwyzard pushed a commit that referenced this pull request Oct 23, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
cb0ae69
fwyzard pushed a commit that referenced this pull request Oct 23, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
df31a97
fwyzard pushed a commit that referenced this pull request Nov 6, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
cbe13d0
fwyzard pushed a commit that referenced this pull request Nov 6, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
4c14c8e
fwyzard pushed a commit that referenced this pull request Nov 6, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
167246b
fwyzard pushed a commit that referenced this pull request Nov 6, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
2eb3b37
fwyzard pushed a commit that referenced this pull request Nov 6, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
e34020b
fwyzard pushed a commit that referenced this pull request Nov 16, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
f670bac
fwyzard pushed a commit that referenced this pull request Nov 16, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
cc7970a
fwyzard pushed a commit that referenced this pull request Nov 16, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
e58604d
fwyzard added a commit that referenced this pull request Nov 27, 2020
@fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
53c6071
fwyzard added a commit that referenced this pull request Nov 28, 2020
@fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
5499eb3
fwyzard pushed a commit that referenced this pull request Dec 25, 2020
@cmsbuild @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
958e4fb
fwyzard pushed a commit that referenced this pull request Dec 26, 2020
@cmsbuild @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
4396a5c
fwyzard added a commit that referenced this pull request Dec 26, 2020
@fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
44b412d
fwyzard added a commit that referenced this pull request Dec 26, 2020
@fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
70e3877
fwyzard pushed a commit that referenced this pull request Dec 29, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
6d6aea3
fwyzard pushed a commit that referenced this pull request Dec 29, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
8c1bc81
fwyzard pushed a commit that referenced this pull request Dec 29, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
8e2e3a5
fwyzard pushed a commit that referenced this pull request Dec 29, 2020
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
cc99012
fwyzard pushed a commit that referenced this pull request Jan 13, 2021
@cmsbuild @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
f3b2b41
fwyzard pushed a commit that referenced this pull request Jan 15, 2021
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
c0d30e4
fwyzard pushed a commit that referenced this pull request Jan 15, 2021
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
4e36c1c
fwyzard pushed a commit that referenced this pull request Mar 23, 2021
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
fd748ed
fwyzard pushed a commit that referenced this pull request Apr 1, 2021
@VinInn @fwyzard
Introduce Cluster Charge Cut, optimize Histogram (bucket sorting) (#171)
6d9630c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwyzard fwyzard fwyzard left review comments

@makortel makortel makortel left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
CMSSW_10_2_5_Patatrack
Development

Successfully merging this pull request may close these issues.
4 participants
@VinInn @cmsbot @fwyzard @makortel