Fix memory initialisation problems in the clusterizer (again) #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makortel
reviewed
Aug 3, 2018
| cudaMallocHost(&fedId_h, sizeof(unsigned char)*WSIZE); | ||
| // data structures size | ||
| constexpr uint32_t vsize = sizeof(GPU::SimpleVector<pixelgpudetails::error_obj>); | ||
| constexpr uint32_t esize = sizeof(pixelgpudetails::error_obj); |
There was a problem hiding this comment.
Since these are defined in the implementation file (and so used only there), I think it would be a bit clearer/safer to define them in an anonymous namespace so that they would not "leak" to the namespace.
fwyzard
added a commit
that referenced
this pull request
Oct 8, 2020
fwyzard
added a commit
that referenced
this pull request
Oct 19, 2020
fwyzard
added a commit
that referenced
this pull request
Oct 20, 2020
fwyzard
added a commit
that referenced
this pull request
Oct 23, 2020
fwyzard
added a commit
that referenced
this pull request
Nov 6, 2020
fwyzard
added a commit
that referenced
this pull request
Nov 16, 2020
fwyzard
pushed a commit
that referenced
this pull request
Dec 25, 2020
fwyzard
added a commit
that referenced
this pull request
Dec 29, 2020
fwyzard
added a commit
that referenced
this pull request
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.