Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed grammar version #49

Merged
merged 1 commit into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,9 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install flake8 pytest
pip install -r requirements.txt
- name: Lint with flake8
run: |
# stop the build if there are Python syntax errors or undefined names
flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
- name: Test with pytest
run: |
pytest
pip install -e .
- name: Install tox and any other packages
run: pip install tox
- name: Run tox
# Run tox using the version of Python in `PATH`
run: tox -e py
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Install using pip (>= 19.0)

```bash
pip install --upgrade pip
pip install git+https://github.com/cms-l1-globaltrigger/tm-editor.git@0.17.0
pip install git+https://github.com/cms-l1-globaltrigger/tm-editor.git@0.17.1
```

## Build
Expand Down
8 changes: 7 additions & 1 deletion changelog
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.17.1] - 2024-06-12
### Fixed
- Loading XML menus with grammar version 0.13.
- Dependency conflict with tox (requiring packaging>=23.2).

## [0.17.0] - 2024-05-16
### Added
- Support for HTMHF (#46).
Expand Down Expand Up @@ -409,7 +414,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- Support most of the algorithm expression language features.

[Unreleased]: https://github.com/cms-l1-globaltrigger/tm-editor/compare/0.17.0...HEAD
[Unreleased]: https://github.com/cms-l1-globaltrigger/tm-editor/compare/0.17.1...HEAD
[0.17.1]: https://github.com/cms-l1-globaltrigger/tm-editor/compare/0.17.0...0.17.1
[0.17.0]: https://github.com/cms-l1-globaltrigger/tm-editor/compare/0.16.0...0.17.0
[0.16.0]: https://github.com/cms-l1-globaltrigger/tm-editor/compare/0.15.4...0.16.0
[0.15.4]: https://github.com/cms-l1-globaltrigger/tm-editor/compare/0.15.3...0.15.4
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
tm-python @ git+https://github.com/cms-l1-globaltrigger/tm-python@0.13.0
Markdown==3.1
packaging==21.3
packaging==23.2
PyQt5==5.14.*
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ packages = find:
install_requires =
tm-python @ git+https://github.com/cms-l1-globaltrigger/tm-python@0.13.0
Markdown==3.1
packaging==21.3
packaging==23.2
PyQt5==5.14.*

[options.packages.find]
Expand Down
5 changes: 4 additions & 1 deletion tests/test_menu.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from tmGrammar import isGate as isOperator
from tmGrammar import isObject, isFunction
from tmEditor.core import XmlDecoder, XmlEncoder
from tmEditor.core.Menu import Menu
from tmEditor.core.Menu import Menu, GrammarVersion
from tmEditor.core.Algorithm import Object, External, Cut, Algorithm
from tmEditor.core.Algorithm import toObject, toExternal
from tmEditor.core.Algorithm import functionObjects, functionCuts, functionObjectsCuts
Expand Down Expand Up @@ -125,3 +125,6 @@ def test_serdes(self):
def test_version(self):
assert tmGrammar.__version__ == UTM_VERSION
assert tmTable.__version__ == UTM_VERSION

def test_grammar_version(self):
assert str(GrammarVersion) == "0.13"
2 changes: 1 addition & 1 deletion tmEditor/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.17.0"
__version__ = "0.17.1"
2 changes: 1 addition & 1 deletion tmEditor/core/Menu.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

__all__ = ["Menu", "GrammarVersion"]

GrammarVersion = Version("0.12")
GrammarVersion = Version("0.13")
"""Supported grammar version."""

kObject: str = "object"
Expand Down
2 changes: 1 addition & 1 deletion tmEditor/core/RemoteVersionInfo.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def load_json(self, data):
if name:
if not uri:
uri = Settings.DefaultScaleSetUri.format(scale_set=name)
url = urljoin(baseurl, uri)
url = urljoin(baseurl, uri)
self.scale_set_name = name
self.scale_set_url = url
# External signal set
Expand Down
Loading