Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes for validated GTT Objects #21

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

NJManganelli
Copy link

This recipe fixes the GTT MHT discrepancy (including a phi range issue, fixing a wraparound past +pi to be in [-pi, 0) instead), as well as a number of other issues with hw values stored for GTT Objects, and adds fields for the Extended TrackJets. In conjunction with https://github.com/cms-l1t-offline/cmssw/pull/1217 and https://github.com/cms-sw/cmssw/pull/44334, there should be agreement on the data members stored for almost all these objects (the above PRs only affect the hwZ0 and hw(Sum)Pt of the TrackJets and Vertices; float values should be unperturbed).

Nick Manganelli added 3 commits March 6, 2024 04:06
…pes + refs to classes_def.xml in DataFormats/L1Trigger: e.g. <class name="ap_range_ref<128,false>"/> and <class name="ap_uint<128>"/>
@NJManganelli
Copy link
Author

I think all comments are addressed currently

@artlbv artlbv merged commit e417545 into cms-l1-dpg:main Mar 11, 2024
@artlbv
Copy link
Contributor

artlbv commented Mar 11, 2024

Merged though I would like to still understand this et<>pt: #21 (comment)

@NJManganelli
Copy link
Author

I committed that locally but forgot to push upstream

diff --git a/python/l1tPh2Nanotables_cff.py b/python/l1tPh2Nanotables_cff.py
index 8740bf9..281340a 100644
--- a/python/l1tPh2Nanotables_cff.py
+++ b/python/l1tPh2Nanotables_cff.py
@@ -63,7 +63,7 @@ gttEtSumTable = cms.EDProducer(
     singleton = cms.bool(True), # the number of entries is variable
     variables = cms.PSet(
         # as in https://github.com/cms-l1t-offline/cmssw/blob/phase2-l1t-integration-14_0_0_pre3/L1Trigger/L1TTrackMatch/interface/L1TkEtMissEmuAlgo.h#L50
-        pt = Var("hwPt() * 0.03125", float, doc = "Track MET"),
+        pt = Var("et", float, doc = "Track MET"),

@artlbv
Copy link
Contributor

artlbv commented Mar 11, 2024

ok, pushed that directly here: 8278525

@NJManganelli
Copy link
Author

Perfect, thanks Artur!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants